> On Feb. 21, 2014, 2:01 p.m., Hugo Trippaers wrote: > > Note that this change does not actually make a difference unless all other > > poms that have mysql as a requirement are modified.
Yes I realized this after changes are done to my original changes related to DB HA. I realized that it is getting bundled even before my original changes. - Damodar Reddy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18353/#review35146 ----------------------------------------------------------- On Feb. 21, 2014, 1:15 p.m., Damodar Reddy Talakanti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18353/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2014, 1:15 p.m.) > > > Review request for cloudstack, Chip Childers and David Nalley. > > > Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6152 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6152 > > > Repository: cloudstack-git > > > Description > ------- > > When we added DB-HA we made mysql-connector-java dependency as provided in > "framework/db/pom.xml". > The licence is not supporting to include this binary in the final package. > We should remove the compile time dependency on this module. > > > Diffs > ----- > > framework/db/pom.xml 7347115 > > Diff: https://reviews.apache.org/r/18353/diff/ > > > Testing > ------- > > Tested that mvn build is not broken because of this change. > Also did a basic sanity run time test that DB functionality is not broken. > > > Thanks, > > Damodar Reddy Talakanti > >
