----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18353/#review35145 -----------------------------------------------------------
Hey, I think the main problem here is that there are references in the source code to com.mysql. Those should be removed or made optional. I've taken this change into commit ac00ab0087ca8f59184121697f7ac4343a694093 Cheers, Hugo - Hugo Trippaers On Feb. 21, 2014, 1:15 p.m., Damodar Reddy Talakanti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18353/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2014, 1:15 p.m.) > > > Review request for cloudstack, Chip Childers and David Nalley. > > > Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6152 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6152 > > > Repository: cloudstack-git > > > Description > ------- > > When we added DB-HA we made mysql-connector-java dependency as provided in > "framework/db/pom.xml". > The licence is not supporting to include this binary in the final package. > We should remove the compile time dependency on this module. > > > Diffs > ----- > > framework/db/pom.xml 7347115 > > Diff: https://reviews.apache.org/r/18353/diff/ > > > Testing > ------- > > Tested that mvn build is not broken because of this change. > Also did a basic sanity run time test that DB functionality is not broken. > > > Thanks, > > Damodar Reddy Talakanti > >
