> -----Original Message----- > From: Chip Childers [mailto:chipchild...@apache.org] > Sent: Wednesday, February 12, 2014 7:43 PM > To: dev@cloudstack.apache.org > Subject: Re: API Calls with key value pairs (Details) > > On Wed, Feb 12, 2014 at 8:24 AM, Devdeep Singh > <devdeep.si...@citrix.com> wrote: > > The user name and password were never there in the key value pair for > creating storage pool. This was done for adding smb as a primary storage and > was done in 4.3 (adding smb as a pool type wasn't available in earlier > release). > > > > Initially user details were passed in the url query string (for smb). > > However, > it would mean adding a password with special characters could fail if the > password wasn't encoded and then the entire url encoded again. So I > updated it to pass smb user information in details. This is required only if a > storage pool being added is of type smb. > > > > Regards, > > Devdeep > > Except it breaks backward compat, right?
No, it will not break backward compat with 4.2.x (or earlier). When smb was added as pool type (in 4.3), the user information was initially in the query string of the url parameter. I made a change to pass it in details. I am not aware of any storage pool type which takes user information in the url parameter. If there is any, the change only affects smb pool type (which has been added in 4.3). Regards, Devdeep
