----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17703/#review34013 -----------------------------------------------------------
test_custom_compute_offering.py <https://reviews.apache.org/r/17703/#comment63933> Add doc strings about information on this test module. Its test nature, dependencies, its workflow if any. test_custom_compute_offering.py <https://reviews.apache.org/r/17703/#comment63932> Clean up spaces in between. test_custom_compute_offering.py <https://reviews.apache.org/r/17703/#comment63937> Please move this test data to new config for test data provided. Check files under marvin/config. test_custom_compute_offering.py <https://reviews.apache.org/r/17703/#comment63934> clean up spaces. Applies at other places as well. test_custom_compute_offering.py <https://reviews.apache.org/r/17703/#comment63939> Do we want this clean up for every test? Or is it part of setUpClass? test_custom_compute_offering.py <https://reviews.apache.org/r/17703/#comment63936> The test flow does not have any ssh access available i believe. Please check. Also. please update the test case flow as comments test_custom_compute_offering.py <https://reviews.apache.org/r/17703/#comment63938> Didnt see clean up for this. But, clean up was called later. test_custom_compute_offering.py <https://reviews.apache.org/r/17703/#comment63935> why so many asserts? Please use the library provided assert for list verification. - Santhosh Edukulla On Feb. 4, 2014, 11:33 a.m., prashant mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17703/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2014, 11:33 a.m.) > > > Review request for cloudstack, sanjeev n, Santhosh Edukulla, and > SrikanteswaraRao Talluri. > > > Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-5951 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-5951 > > > Repository: cloudstack-git > > > Description > ------- > > with dynamic computer offering feature service offering can be created > without cpunumber,cpuspeed , memory and these values can be provided at time > of vm deployment > > issue in base.py: cpuspeed,cpunumber,memory is compulsory to create SO and > these values cant be passed in deployVirtualMachine API. > > Fix: cpuspeed, cpunumber,memory will be optional parameter, and these values > can be passed in deployVirtualMachine API. > > > Diffs > ----- > > test_custom_compute_offering.py PRE-CREATION > tools/marvin/marvin/lib/base.py aa23029 > > Diff: https://reviews.apache.org/r/17703/diff/ > > > Testing > ------- > > Tested vm deployment with regular computer offering and custom compute > offerings > > > Thanks, > > prashant mishra > >
