----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17703/ -----------------------------------------------------------
Review request for cloudstack, sanjeev n, Santhosh Edukulla, and SrikanteswaraRao Talluri. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-5951 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-5951 Repository: cloudstack-git Description ------- with dynamic computer offering feature service offering can be created without cpunumber,cpuspeed , memory and these values can be provided at time of vm deployment issue in base.py: cpuspeed,cpunumber,memory is compulsory to create SO and these values cant be passed in deployVirtualMachine API. Fix: cpuspeed, cpunumber,memory will be optional parameter, and these values can be passed in deployVirtualMachine API. Diffs ----- test_custom_compute_offering.py PRE-CREATION tools/marvin/marvin/lib/base.py aa23029 Diff: https://reviews.apache.org/r/17703/diff/ Testing ------- Tested vm deployment with regular computer offering and custom compute offerings Thanks, prashant mishra
