----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17391/#review33096 -----------------------------------------------------------
Ship it! Please dont apply it to master or 4.3 branch, apply this to topic branch created. Once tested with other changes, we will move to main branches. Since 4.3 release is near, we agreed not to commit any changes in marvin for now. - Santhosh Edukulla On Jan. 28, 2014, 12:46 p.m., prashant mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17391/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2014, 12:46 p.m.) > > > Review request for cloudstack, Santhosh Edukulla and SrikanteswaraRao Talluri. > > > Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-5951 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-5951 > > > Repository: cloudstack-git > > > Description > ------- > > with dynamic computer offering feature service offering can be created > without cpunumber,cpuspeed , memory and these values can be provided at time > of vm deployment > > issue: cpuspeed,cpunumber,memory is compulsory to create SO and these values > cant be passed in deployVirtualMachine API. > > Fix: cpuspeed, cpunumber,memory will be optional parameter, and these values > can be passed in deployVirtualMachine API. > > > Diffs > ----- > > tools/marvin/marvin/integration/lib/base.py 409530c > > Diff: https://reviews.apache.org/r/17391/diff/ > > > Testing > ------- > > Tested vm deployment with regular computer offering and custom compute > offerings > > > Thanks, > > prashant mishra > >
