----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17391/#review32827 -----------------------------------------------------------
tools/marvin/marvin/integration/lib/base.py <https://reviews.apache.org/r/17391/#comment61829> you want a logical "and" i believe? tools/marvin/marvin/integration/lib/base.py <https://reviews.apache.org/r/17391/#comment61830> I believe we wanted services["virtual_machine"] to verify the keys tools/marvin/marvin/integration/lib/base.py <https://reviews.apache.org/r/17391/#comment61831> Remove flower braces and use a tuple if needed here. tools/marvin/marvin/integration/lib/base.py <https://reviews.apache.org/r/17391/#comment61832> I believe we wanted to verify in services["virtual_machine"] instead of services altogether for the below: for k,v in services.items(): tools/marvin/marvin/integration/lib/base.py <https://reviews.apache.org/r/17391/#comment61833> Applies same here as well. - Santhosh Edukulla On Jan. 27, 2014, 11:09 a.m., prashant mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17391/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2014, 11:09 a.m.) > > > Review request for cloudstack and SrikanteswaraRao Talluri. > > > Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-5951 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-5951 > > > Repository: cloudstack-git > > > Description > ------- > > with dynamic computer offering feature service offering can be created > without cpunumber,cpuspeed , memory and these values can be provided at time > of vm deployment > > issue: cpuspeed,cpunumber,memory is compulsory to create SO and these values > cant be passed in deployVirtualMachine API. > > Fix: cpuspeed, cpunumber,memory will be optional parameter, and these values > can be passed in deployVirtualMachine API. > > > Diffs > ----- > > tools/marvin/marvin/integration/lib/base.py 409530c > tools/marvin/test_deploy_vms_with_dynamic_compute_offesrings.py > PRE-CREATION > > Diff: https://reviews.apache.org/r/17391/diff/ > > > Testing > ------- > > Tested vm deployment with regular computer offering and custom compute > offerings > > > Thanks, > > prashant mishra > >
