> On Dec. 12, 2013, 12:53 p.m., Santhosh Edukulla wrote: > > test/integration/component/test_advancedsg_networks.py, line 340 > > <https://reviews.apache.org/r/16178/diff/1/?file=396533#file396533line340> > > > > Ideally, deletion failure is also a failure assuming CS was not able to > > delete it under some flow. But raising only if one entity failed and > > leaving others still may effect further flow\tests. If they try to create > > the entities with similar naming. May be dont raise and continue with > > further deletion and fail the test case. Here, the failure is not exactly a > > TC failure, but still can assume CS have a bug to delete.
Done > On Dec. 12, 2013, 12:53 p.m., Santhosh Edukulla wrote: > > tools/marvin/marvin/integration/lib/common.py, line 778 > > <https://reviews.apache.org/r/16178/diff/1/?file=396537#file396537line778> > > > > But, if it is not there in the usedVlanIds, then breaking and doing > > what? > > > > If it is there we continue, at the end of this loop what we achieved? > > and the variable shared_ntwk_vlan variable is never used thereafter. Shared_ntwk_vlan is returned from the function at the end. We search for the vlan id which is not in use (through the loop) and when we get it, we break, and we return. > On Dec. 12, 2013, 12:53 p.m., Santhosh Edukulla wrote: > > test/integration/component/test_advancedsg_networks.py, line 1339 > > <https://reviews.apache.org/r/16178/diff/1/?file=396533#file396533line1339> > > > > Are we deleting the resources created here? Every resource created in the test case has either added to cleanup, or deleted as part of the test case. There are no cleanup issues here. The purpose of the test case is to try to delete a shared network which is not in use. > On Dec. 12, 2013, 12:53 p.m., Santhosh Edukulla wrote: > > test/integration/component/test_advancedsg_networks.py, line 1309 > > <https://reviews.apache.org/r/16178/diff/1/?file=396533#file396533line1309> > > > > We didnt deleted the resources created? The resources are added to the cleanup list. > On Dec. 12, 2013, 12:53 p.m., Santhosh Edukulla wrote: > > test/integration/component/test_advancedsg_networks.py, line 893 > > <https://reviews.apache.org/r/16178/diff/1/?file=396533#file396533line893> > > > > Is comment wrong here? Yes, instead of "admin" account, it should be "user" account. Fixed this. > On Dec. 12, 2013, 12:53 p.m., Santhosh Edukulla wrote: > > test/integration/component/test_advancedsg_networks.py, line 1051 > > <https://reviews.apache.org/r/16178/diff/1/?file=396533#file396533line1051> > > > > Is there a failed criteria for this TC? According to test plan, account specific shared networks with same subnet and vlan should get created in different accounts. But this is not happening right now. Further investigation needed to check if this is test case issue or product issue, hence skipped for now. - Ashutosh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16178/#review30255 ----------------------------------------------------------- On Dec. 11, 2013, 8:30 a.m., Ashutosh Kelkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16178/ > ----------------------------------------------------------- > > (Updated Dec. 11, 2013, 8:30 a.m.) > > > Review request for cloudstack, Girish Shilamkar, Santhosh Edukulla, and > SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-2237 > https://issues.apache.org/jira/browse/CLOUDSTACK-2237 > > > Repository: cloudstack-git > > > Description > ------- > > Adding Automation tests for feature "Security Group Isolation in advanced > zone". > > @Santhosh: Please check the change in configGenerator file. Made changes to > take relative path. > > > Diffs > ----- > > test/integration/component/test_advancedsg_networks.py 4834351 > tools/marvin/marvin/config/config.cfg PRE-CREATION > tools/marvin/marvin/configGenerator.py 6d5b70d > tools/marvin/marvin/integration/lib/base.py 86f962a > tools/marvin/marvin/integration/lib/common.py 096b073 > > Diff: https://reviews.apache.org/r/16178/diff/ > > > Testing > ------- > > Tested locally on Advanced zone setup with security group enabled. > > > Thanks, > > Ashutosh Kelkar > >
