----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16178/#review30255 -----------------------------------------------------------
test/integration/component/test_advancedsg_networks.py <https://reviews.apache.org/r/16178/#comment57922> Ideally, deletion failure is also a failure assuming CS was not able to delete it under some flow. But raising only if one entity failed and leaving others still may effect further flow\tests. If they try to create the entities with similar naming. May be dont raise and continue with further deletion and fail the test case. Here, the failure is not exactly a TC failure, but still can assume CS have a bug to delete. test/integration/component/test_advancedsg_networks.py <https://reviews.apache.org/r/16178/#comment57923> Is comment wrong here? test/integration/component/test_advancedsg_networks.py <https://reviews.apache.org/r/16178/#comment57924> Is there a failed criteria for this TC? test/integration/component/test_advancedsg_networks.py <https://reviews.apache.org/r/16178/#comment57925> We didnt deleted the resources created? test/integration/component/test_advancedsg_networks.py <https://reviews.apache.org/r/16178/#comment57926> Are we deleting the resources created here? tools/marvin/marvin/integration/lib/common.py <https://reviews.apache.org/r/16178/#comment57921> But, if it is not there in the usedVlanIds, then breaking and doing what? If it is there we continue, at the end of this loop what we achieved? and the variable shared_ntwk_vlan variable is never used thereafter. - Santhosh Edukulla On Dec. 11, 2013, 8:30 a.m., Ashutosh Kelkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16178/ > ----------------------------------------------------------- > > (Updated Dec. 11, 2013, 8:30 a.m.) > > > Review request for cloudstack, Girish Shilamkar, Santhosh Edukulla, and > SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-2237 > https://issues.apache.org/jira/browse/CLOUDSTACK-2237 > > > Repository: cloudstack-git > > > Description > ------- > > Adding Automation tests for feature "Security Group Isolation in advanced > zone". > > @Santhosh: Please check the change in configGenerator file. Made changes to > take relative path. > > > Diffs > ----- > > test/integration/component/test_advancedsg_networks.py 4834351 > tools/marvin/marvin/config/config.cfg PRE-CREATION > tools/marvin/marvin/configGenerator.py 6d5b70d > tools/marvin/marvin/integration/lib/base.py 86f962a > tools/marvin/marvin/integration/lib/common.py 096b073 > > Diff: https://reviews.apache.org/r/16178/diff/ > > > Testing > ------- > > Tested locally on Advanced zone setup with security group enabled. > > > Thanks, > > Ashutosh Kelkar > >
