Fixed the build script a 3rd round of voting is due now, so please hold on voting for this round.
-abhi On 13/12/13 10:57 am, "Abhinandan Prateek" <abhinandan.prat...@citrix.com> wrote: > The build script explicitly removes the SNAPSHOT from the version before >it builds. >AS per CLOUDSTACK-4827 the the xapi version in deps/XenServerJava/pom.xml >should not change. >But then I see someone explicitly add the following in >tools/build/build_asf.sh : > >mv deps/XenServerJava/pom.xml.versionsBackup deps/XenServerJava/pom.xml > >perl -pi -e "s/-SNAPSHOT//" deps/XenServerJava/pom.xml >perl -pi -e "s/-SNAPSHOT//" tools/apidoc/pom.xml > >Can someone comment why the above lines were added ? > > >-abhi > >On 13/12/13 10:42 am, "Abhinandan Prateek" <abhinandan.prat...@citrix.com> >wrote: > >>On 12/12/13 10:00 pm, "Wei ZHOU" <ustcweiz...@gmail.com> wrote: >> >>>Abhi, >>>I have two problems >>>(1) I can not checkout the commit >>>43350d64ce66e366f08a9fa13ad09bca462b66da, >>>it looks not exist >>>(2) the xapi version in deps/XenServerJava/pom.xml should not be changed >>>when you bump the version from 4.2.1-SNAPSHOT to 4.2.1. (see >>>CLOUDSTACK-4827) >> >>Ok, I can see that the build script is trying to revert back the version >>to 4.2.1-SNAPSHOT but in the final build the version is not reverted. >>Will be checking what is causing that. >> >>-abhi >> >
