----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14595/#review27278 -----------------------------------------------------------
Ship it! Thanks for the patch! dfa0678 on master. Please ensure your editor uses only spaces and no tabs. There were several syntax and indentation errors in the patch probably as a result of that. Also please ensure not to break pep8 in marvin's core. - Prasanna Santhanam On Oct. 11, 2013, 12:51 p.m., Santhosh Edukulla wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14595/ > ----------------------------------------------------------- > > (Updated Oct. 11, 2013, 12:51 p.m.) > > > Review request for cloudstack, daan Hoogland and Prasanna Santhanam. > > > Bugs: 4832 > https://issues.apache.org/jira/browse/4832 > > > Repository: cloudstack-git > > > Description > ------- > > adding support to marvin for https. We will allow user to specify whether to > usehttps or not using three params > > > useHttps, certCAPath, certPath - the params are self explanatory > > > Diffs > ----- > > setup/dev/advanced.cfg 4a48399 > tools/marvin/marvin/cloudstackConnection.py 686c533 > tools/marvin/marvin/cloudstackTestClient.py 36f7f8d > tools/marvin/marvin/configGenerator.py a966ae0 > tools/marvin/marvin/deployDataCenter.py beed8c8 > > Diff: https://reviews.apache.org/r/14595/diff/ > > > Testing > ------- > > Tested against http. Setting up https environment for testing. Will > appreciate a test if anyone has https enabled on their setup > > > Thanks, > > Santhosh Edukulla > >
