----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14595/#review27185 -----------------------------------------------------------
The params are self explanatory indeed, i like them. The concern I have with them is regarding backward compatibility of the interface. I don't (yet) use the BVT suite due to lack of knowledge on my side. I use the connection object and api calls directly and fear the my present scripts will break with this code. This would warant a major version upgrade for marvin. - daan Hoogland On Oct. 11, 2013, 12:51 p.m., Santhosh Edukulla wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14595/ > ----------------------------------------------------------- > > (Updated Oct. 11, 2013, 12:51 p.m.) > > > Review request for cloudstack, daan Hoogland and Prasanna Santhanam. > > > Bugs: 4832 > https://issues.apache.org/jira/browse/4832 > > > Repository: cloudstack-git > > > Description > ------- > > adding support to marvin for https. We will allow user to specify whether to > usehttps or not using three params > > > useHttps, certCAPath, certPath - the params are self explanatory > > > Diffs > ----- > > setup/dev/advanced.cfg 4a48399 > tools/marvin/marvin/cloudstackConnection.py 686c533 > tools/marvin/marvin/cloudstackTestClient.py 36f7f8d > tools/marvin/marvin/configGenerator.py a966ae0 > tools/marvin/marvin/deployDataCenter.py beed8c8 > > Diff: https://reviews.apache.org/r/14595/diff/ > > > Testing > ------- > > Tested against http. Setting up https environment for testing. Will > appreciate a test if anyone has https enabled on their setup > > > Thanks, > > Santhosh Edukulla > >
