> On June 17, 2013, 10:32 a.m., Prasanna Santhanam wrote: > > test/integration/component/test_memory_limits.py, line 184 > > <https://reviews.apache.org/r/11626/diff/1/?file=300447#file300447line184> > > > > what if networks is an empty list? []
Removed this method as it is no longer used anywhere. > On June 17, 2013, 10:32 a.m., Prasanna Santhanam wrote: > > test/integration/component/test_memory_limits.py, line 172 > > <https://reviews.apache.org/r/11626/diff/1/?file=300447#file300447line172> > > > > Same here, anyone reading the test should be able to make sense of > > Network.list followed by assert faster than having to hunt down what > > get_network does each time. Removed the method. > On June 17, 2013, 10:32 a.m., Prasanna Santhanam wrote: > > test/integration/component/test_memory_limits.py, line 145 > > <https://reviews.apache.org/r/11626/diff/1/?file=300447#file300447line145> > > > > Do we need this method? I think keeping the VM creation step > > (VirtualMachine.create, asserts1, assert2) is easier than refactoring this > > into a test specific method for each test suite. This has been factored into different function for readability purpose. The test cases become too lengthy if we put inline statements instead of function call, compelling the reader scroll up and down to read one test case. - Gaurav ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11626/#review21967 ----------------------------------------------------------- On Aug. 9, 2013, 1:21 p.m., Gaurav Aradhye wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11626/ > ----------------------------------------------------------- > > (Updated Aug. 9, 2013, 1:21 p.m.) > > > Review request for cloudstack, sailaja mada, Sanjay Tripathi, and Prasanna > Santhanam. > > > Repository: cloudstack-git > > > Description > ------- > > Adding resource limit tests related to Memory. Changes suggested in CPU > resource limit tests which are applicable here are incorporated too. > > Updated test plan is available here: > https://cwiki.apache.org/confluence/download/attachments/30757590/LimitResourcesTestPlanUpdate5.xlsx?version=1&modificationDate=1366952352000 > > > Diffs > ----- > > test/integration/component/memory_limits/test_domain_limits.py PRE-CREATION > test/integration/component/memory_limits/test_maximum_limits.py > PRE-CREATION > test/integration/component/memory_limits/test_memory_limits.py PRE-CREATION > test/integration/component/memory_limits/test_project_limits.py > PRE-CREATION > tools/marvin/marvin/integration/lib/base.py 695edf7 > tools/marvin/marvin/integration/lib/common.py 4f5acef > > Diff: https://reviews.apache.org/r/11626/diff/ > > > Testing > ------- > > > Thanks, > > Gaurav Aradhye > >
