----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11626/#review25218 -----------------------------------------------------------
test/integration/component/memory_limits/test_domain_limits.py <https://reviews.apache.org/r/11626/#comment49994> This is not required as changeServiceOffering should update the resource count. test/integration/component/memory_limits/test_domain_limits.py <https://reviews.apache.org/r/11626/#comment49995> same reason, please remove this update call. test/integration/component/memory_limits/test_domain_limits.py <https://reviews.apache.org/r/11626/#comment49996> Please change the "update resource count" to "list resource count" as we are list the resource count in the test. test/integration/component/memory_limits/test_domain_limits.py <https://reviews.apache.org/r/11626/#comment49997> same reason, please change the description accordingly. test/integration/component/memory_limits/test_domain_limits.py <https://reviews.apache.org/r/11626/#comment49998> please change the description accordingly. test/integration/component/memory_limits/test_domain_limits.py <https://reviews.apache.org/r/11626/#comment50000> api_client should point to cdamin_2. test/integration/component/memory_limits/test_memory_limits.py <https://reviews.apache.org/r/11626/#comment50004> please change the test name as per the test description and implementation. Also change the description of the test accordingly. test/integration/component/memory_limits/test_memory_limits.py <https://reviews.apache.org/r/11626/#comment50005> This update call is not required. test/integration/component/memory_limits/test_memory_limits.py <https://reviews.apache.org/r/11626/#comment50006> This update call is not required. test/integration/component/memory_limits/test_memory_limits.py <https://reviews.apache.org/r/11626/#comment50007> change the description of test according to the test implementation. tools/marvin/marvin/integration/lib/common.py <https://reviews.apache.org/r/11626/#comment50009> remove the resource type 12 and 13 as they are not yet implemented. tools/marvin/marvin/integration/lib/common.py <https://reviews.apache.org/r/11626/#comment50010> please remove the resource type 12 and 13. - Sanjay Tripathi On Aug. 9, 2013, 7:51 a.m., Gaurav Aradhye wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11626/ > ----------------------------------------------------------- > > (Updated Aug. 9, 2013, 7:51 a.m.) > > > Review request for cloudstack, sailaja mada, Sanjay Tripathi, and Prasanna > Santhanam. > > > Repository: cloudstack-git > > > Description > ------- > > Adding resource limit tests related to Memory. Changes suggested in CPU > resource limit tests which are applicable here are incorporated too. > > Updated test plan is available here: > https://cwiki.apache.org/confluence/download/attachments/30757590/LimitResourcesTestPlanUpdate5.xlsx?version=1&modificationDate=1366952352000 > > > Diffs > ----- > > test/integration/component/memory_limits/test_domain_limits.py PRE-CREATION > test/integration/component/memory_limits/test_maximum_limits.py > PRE-CREATION > test/integration/component/memory_limits/test_memory_limits.py PRE-CREATION > test/integration/component/memory_limits/test_project_limits.py > PRE-CREATION > tools/marvin/marvin/integration/lib/base.py 695edf7 > tools/marvin/marvin/integration/lib/common.py 4f5acef > > Diff: https://reviews.apache.org/r/11626/diff/ > > > Testing > ------- > > > Thanks, > > Gaurav Aradhye > >
