sudo87 commented on PR #301:
URL: 
https://github.com/apache/cloudstack-terraform-provider/pull/301#issuecomment-5521538754

   @bddvlpr could you please address following comments:
   
   - provider.go removes DataSourcesMap entries for 
cloudstack_autoscale_policy, cloudstack_autoscale_vm_group, 
cloudstack_autoscale_vm_profile. Unrelated to this PR, breaks those data 
sources.
   - data_source_cloudstack_disk_offering.go — filtering by customized always 
fails with "Unknown filter field customized" since the API's JSON key is 
iscustomized, not customized.
   - resource_cloudstack_disk_offering.go — customized is 
Optional+Default:false+ForceNew but not Computed. When both disk_size and 
customized are omitted, Create forces customized=true server-side, but state 
then conflicts with the schema default on every subsequent plan, causing 
perpetual destroy/recreate. Mark it (and likely disk_size) Computed: true to 
fix.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to