Copilot commented on code in PR #301: URL: https://github.com/apache/cloudstack-terraform-provider/pull/301#discussion_r3921683449
########## website/docs/r/disk_offering.html.markdown: ########## @@ -27,7 +27,22 @@ The following arguments are supported: * `name` - (Required) The name of the disk offering. * `display_text` - (Required) The display text of the disk offering. -* `disk_size` - (Required) The size of the disk offering in GB. +* `disk_size` - (Optional) The size of the disk offering in GB. Conflicts with + `customized`. If neither `disk_size` nor `customized` is set, the offering is + created as customized. Changing this forces a new resource to be created. +* `customized` - (Optional) Whether the disk offering allows a custom disk size + to be specified at deployment time. Conflicts with `disk_size`, and is + implied when `disk_size` is omitted. Defaults to `false`. Changing this + forces a new resource to be created. Review Comment: The `customized` description is internally inconsistent: it says `customized` is implied when `disk_size` is omitted, but also says it defaults to `false`. Only one of those can be true; given the described behavior, the docs should explain the conditional default (or explicitly require users to set `customized = true` when omitting `disk_size`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
