Copilot commented on code in PR #149:
URL: https://github.com/apache/cloudstack-go/pull/149#discussion_r3568363590


##########
SECURITY.md:
##########
@@ -0,0 +1,35 @@
+<!--
+SPDX-License-Identifier: Apache-2.0
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    https://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+-->
+
+# Security Policy
+
+## Reporting a Vulnerability
+
+`apache/cloudstack-go` follows the [Apache Software Foundation security 
process](https://www.apache.org/security/).
+Please report suspected vulnerabilities privately to `[email protected]`; do 
not
+open public GitHub issues or pull requests for security reports.
+
+## Threat Model
+
+`apache/cloudstack-go` is part of the Apache CloudStack project and is covered 
by the
+**project-wide CloudStack threat model** rather than a per-repository copy. 
What the
+project treats as in scope and out of scope, the security properties it 
provides and
+disclaims, the adversary model, and how findings are triaged are documented in 
that
+model: <https://github.com/apache/cloudstack/blob/main/THREAT_MODEL.md>.
+
+(That link resolves once the project-wide model lands on `apache/cloudstack`'s
+`main` branch — see apache/cloudstack#13293. A thin 
`cloudstack-cloudstack-go`-specific

Review Comment:
   Typo in the repo name: this parenthetical refers to a 
`cloudstack-cloudstack-go`-specific addendum, but the repository is 
`cloudstack-go`.



##########
SECURITY.md:
##########
@@ -0,0 +1,35 @@
+<!--
+SPDX-License-Identifier: Apache-2.0
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    https://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+-->

Review Comment:
   The PR description says `SECURITY.md` carries the full ASF license header, 
and most files in this repo use the standard ASF header format (e.g., 
`cloudstack/cloudstack.go:2-16`). The new `SECURITY.md` currently uses a 
shorter Apache-2.0 notice that doesn’t include the usual “Licensed to the 
Apache Software Foundation (ASF)…” text; consider switching to the standard 
header for consistency/compliance (or update the PR description if the shorter 
header is intentional).



##########
.rat-excludes:
##########
@@ -3,3 +3,8 @@ go.mod
 go.sum
 rat-report.txt
 apache-rat-0.17
+
+# Security-model scaffold (carries an SPDX header; exempted
+# from RAT for setups that don't scan Markdown headers).
+AGENTS.md
+SECURITY.md

Review Comment:
   Excluding `AGENTS.md` and `SECURITY.md` from Apache RAT means these new 
first-party policy documents won’t be license-checked at all, even though they 
already include Apache-2.0/SPDX headers. Since this repo runs RAT in CI 
(`.github/workflows/rat.yaml`), it’s better to keep these files in scope and 
adjust their headers if RAT has trouble recognizing them, rather than exempting 
them.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to