----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12808/#review23837 -----------------------------------------------------------
Commit 0010faee4bac8ebb32ceb95ca6ff6b02b4013cba in branch refs/heads/ldapplugin from Harikrishna Patnala [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=0010fae ] Fix for CLOUDSTACK-2536 Removing memoryovercommitratio and cpuovercommitratio parameters from addCluster and updateCluster APIs, since these can be configurable using updateConfiguration API at cluster level. By default while creating cluster these values are taken from global configuration parameters. - ASF Subversion and Git Services On July 25, 2013, 7:19 a.m., Harikrishna Patnala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12808/ > ----------------------------------------------------------- > > (Updated July 25, 2013, 7:19 a.m.) > > > Review request for cloudstack, Koushik Das and Nitin Mehta. > > > Bugs: CLOUDSTACK-1528 and CLOUDSTACK-2536 > > > Repository: cloudstack-git > > > Description > ------- > > CLOUDSTACK-2536: updating parameters (cpu/memory)overcommit ratio and > (cpu/memory).overprosioning.factor are redundant(cluster level) > There are two APIs updateCluster and UpdateConfiguration where we can update > these parameters. Ideally this should get updated using updateConfiguration > API, so removing from updateCluster API > > > Diffs > ----- > > api/src/com/cloud/resource/ResourceService.java 25298cc > api/src/org/apache/cloudstack/api/ApiConstants.java 0550a39 > api/src/org/apache/cloudstack/api/command/admin/cluster/AddClusterCmd.java > c6ca9bc6 > > api/src/org/apache/cloudstack/api/command/admin/cluster/UpdateClusterCmd.java > a14f905 > server/src/com/cloud/configuration/ConfigurationManagerImpl.java 9bc8efd > server/src/com/cloud/resource/ResourceManagerImpl.java 342b9fd > server/test/com/cloud/resource/MockResourceManagerImpl.java 2c66134 > > Diff: https://reviews.apache.org/r/12808/diff/ > > > Testing > ------- > > > Thanks, > > Harikrishna Patnala > >
