----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12808/#review23821 -----------------------------------------------------------
server/src/com/cloud/configuration/ConfigurationManagerImpl.java <https://reviews.apache.org/r/12808/#comment47664> Provide the exact parameter name instead of the set of value. server/src/com/cloud/configuration/ConfigurationManagerImpl.java <https://reviews.apache.org/r/12808/#comment47665> Use a variable to store the message and use it. - Koushik Das On July 23, 2013, 11:41 a.m., Harikrishna Patnala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12808/ > ----------------------------------------------------------- > > (Updated July 23, 2013, 11:41 a.m.) > > > Review request for cloudstack, Koushik Das and Nitin Mehta. > > > Bugs: CLOUDSTACK-1528 and CLOUDSTACK-2536 > > > Repository: cloudstack-git > > > Description > ------- > > CLOUDSTACK-2536: updating parameters (cpu/memory)overcommit ratio and > (cpu/memory).overprosioning.factor are redundant(cluster level) > There are two APIs updateCluster and UpdateConfiguration where we can update > these parameters. Ideally this should get updated using updateConfiguration > API, so removing from updateCluster API > > > Diffs > ----- > > api/src/com/cloud/resource/ResourceService.java 25298cc > api/src/org/apache/cloudstack/api/ApiConstants.java 0550a39 > api/src/org/apache/cloudstack/api/command/admin/cluster/AddClusterCmd.java > c6ca9bc6 > > api/src/org/apache/cloudstack/api/command/admin/cluster/UpdateClusterCmd.java > a14f905 > server/src/com/cloud/configuration/ConfigurationManagerImpl.java 92178c9 > server/src/com/cloud/resource/ResourceManagerImpl.java d7652f4 > server/test/com/cloud/resource/MockResourceManagerImpl.java 2c66134 > > Diff: https://reviews.apache.org/r/12808/diff/ > > > Testing > ------- > > > Thanks, > > Harikrishna Patnala > >
