vishesh92 commented on code in PR #64:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/64#discussion_r1513882158
##########
cloudstack/resource_cloudstack_service_offering.go:
##########
@@ -42,6 +42,61 @@ func resourceCloudStackServiceOffering() *schema.Resource {
Type: schema.TypeString,
Required: true,
},
+ "cpu_number": {
+ Description: "Number of CPU cores",
+ Type: schema.TypeInt,
+ Optional: true,
+ ForceNew: true,
+ },
+ "cpu_speed": {
+ Description: "Speed of CPU in Mhz",
+ Type: schema.TypeInt,
+ Optional: true,
+ ForceNew: true,
+ },
+ "host_tags": {
+ Description: "The host tag for this service
offering",
+ Type: schema.TypeString,
+ Optional: true,
+ },
+ "limit_cpu_use": {
+ Description: "Restrict the CPU usage to
committed service offering",
+ Type: schema.TypeBool,
+ Optional: true,
+ ForceNew: true,
+ Default: false,
+ },
+ "memory": {
+ Description: "The total memory of the service
offering in MB",
+ Type: schema.TypeInt,
+ Optional: true,
+ ForceNew: true,
+ },
+ "offer_ha": {
+ Description: "The HA for the service offering",
+ Type: schema.TypeBool,
+ Optional: true,
+ ForceNew: true,
+ Default: false,
+ },
+ "storage_type": {
+ Description: "The storage type of the service
offering. Values are local and shared",
+ Type: schema.TypeString,
+ Optional: true,
+ ForceNew: true,
+ Default: "local",
Review Comment:
```suggestion
Default: "shared",
```
shared is the default for the API. Let's keep the same here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
