Good work Ian, enjoy the weekend
On 29 June 2013 20:54, Sebastien Goasguen <run...@gmail.com> wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12162/#review22568 > ----------------------------------------------------------- > > Ship it! > > > applied to master with 15a6844784142141af22224489a57d7d748c6687 > also applied on 4.1 and 4.2 > > please mark review as submitted > > you need to check that it gets added to the devguide... > > thanks > > - Sebastien Goasguen > > > On June 28, 2013, 12:37 p.m., Ian Duffy wrote: > > > > ----------------------------------------------------------- > > This is an automatically generated e-mail. To reply, visit: > > https://reviews.apache.org/r/12162/ > > ----------------------------------------------------------- > > > > (Updated June 28, 2013, 12:37 p.m.) > > > > > > Review request for cloudstack and Sebastien Goasguen. > > > > > > Repository: cloudstack-git > > > > > > Description > > ------- > > > > Add documentation on creating a simple "helloWorld" API command plugin. > > > > > > Diffs > > ----- > > > > docs/en-US/creating-a-plugin.xml PRE-CREATION > > docs/en-US/creating-my-first-plugin.xml PRE-CREATION > > docs/en-US/plugin-development.xml PRE-CREATION > > > > Diff: https://reviews.apache.org/r/12162/diff/ > > > > > > Testing > > ------- > > > > Built with publican, reviewed the build pdf in adobe reader. > > There was funky text indentation between pages... this seems to be a > global problem though. > > > > > > Thanks, > > > > Ian Duffy > > > > > >
