----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11540/#review21418 -----------------------------------------------------------
Heya, You know you can commit this directly? No need to go through the review process now you are a committer. However, since you opted to go through the review board, here is my review :D Just a couple of small remarks, nothing big so feel free to address the remarks and commit. I'm also missing the changes to the application context for oss and nonoss build, so this will not be loaded at the moment. You probably need to add those. Cheers, Hugo P.S. Can you send me some details on the Stratosphere solution? I would like to include this in my presentation on SDN in Cloudstack for CCC. plugins/network-elements/stratosphere-ssp/src/com/cloud/network/element/SspClient.java <https://reviews.apache.org/r/11540/#comment44342> is this correct? The other uris use /ssp.v1/* plugins/network-elements/stratosphere-ssp/src/com/cloud/network/guru/SspGuestNetworkGuru.java <https://reviews.apache.org/r/11540/#comment44341> Can you remove the author tag? plugins/network-elements/stratosphere-ssp/src/com/cloud/network/guru/SspGuestNetworkGuru.java <https://reviews.apache.org/r/11540/#comment44343> Here it should also check if the physical network type has the isolation type (SSP) that can be handled by this plugin. plugins/network-elements/stratosphere-ssp/test/com/cloud/network/element/SspClientTest.java <https://reviews.apache.org/r/11540/#comment44344> Please double check whitespace plugins/network-elements/stratosphere-ssp/test/com/cloud/network/element/SspElementTest.java <https://reviews.apache.org/r/11540/#comment44345> Please remove the tabs and replace them with spaces. - Hugo Trippaers On May 31, 2013, 12:44 a.m., Hiroaki Kawai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11540/ > ----------------------------------------------------------- > > (Updated May 31, 2013, 12:44 a.m.) > > > Review request for cloudstack, Hugo Trippaers and Chiradeep Vittal. > > > Description > ------- > > Stratosphre SSP is an SDN controller that controls or brokers physical and or > virtual network devices. Stratosphere SSP will build a vxlan backed overlay > network. The plugin will contact SSP api to setup L2 networking environment > for cloudstack 4.2. > > This plugin will provide NetworkElement and NetworkGuru to enable the > element. The service provided by this plugin is "connectivity" service. > > > This addresses bug CLOUDSTACK-2756. > > > Diffs > ----- > > api/src/com/cloud/network/PhysicalNetwork.java c521dc4 > plugins/network-elements/stratosphere-ssp/pom.xml PRE-CREATION > > plugins/network-elements/stratosphere-ssp/src/com/cloud/api/commands/AddSspCmd.java > PRE-CREATION > > plugins/network-elements/stratosphere-ssp/src/com/cloud/api/commands/DeleteSspCmd.java > PRE-CREATION > > plugins/network-elements/stratosphere-ssp/src/com/cloud/api/response/SspResponse.java > PRE-CREATION > > plugins/network-elements/stratosphere-ssp/src/com/cloud/network/dao/SspCredentialDao.java > PRE-CREATION > > plugins/network-elements/stratosphere-ssp/src/com/cloud/network/dao/SspCredentialDaoImpl.java > PRE-CREATION > > plugins/network-elements/stratosphere-ssp/src/com/cloud/network/dao/SspCredentialVO.java > PRE-CREATION > > plugins/network-elements/stratosphere-ssp/src/com/cloud/network/dao/SspTenantDao.java > PRE-CREATION > > plugins/network-elements/stratosphere-ssp/src/com/cloud/network/dao/SspTenantDaoImpl.java > PRE-CREATION > > plugins/network-elements/stratosphere-ssp/src/com/cloud/network/dao/SspTenantVO.java > PRE-CREATION > > plugins/network-elements/stratosphere-ssp/src/com/cloud/network/dao/SspUuidDao.java > PRE-CREATION > > plugins/network-elements/stratosphere-ssp/src/com/cloud/network/dao/SspUuidDaoImpl.java > PRE-CREATION > > plugins/network-elements/stratosphere-ssp/src/com/cloud/network/dao/SspUuidVO.java > PRE-CREATION > > plugins/network-elements/stratosphere-ssp/src/com/cloud/network/element/SspClient.java > PRE-CREATION > > plugins/network-elements/stratosphere-ssp/src/com/cloud/network/element/SspElement.java > PRE-CREATION > > plugins/network-elements/stratosphere-ssp/src/com/cloud/network/element/SspManager.java > PRE-CREATION > > plugins/network-elements/stratosphere-ssp/src/com/cloud/network/element/SspService.java > PRE-CREATION > > plugins/network-elements/stratosphere-ssp/src/com/cloud/network/guru/SspGuestNetworkGuru.java > PRE-CREATION > > plugins/network-elements/stratosphere-ssp/test/com/cloud/network/element/SspClientTest.java > PRE-CREATION > > plugins/network-elements/stratosphere-ssp/test/com/cloud/network/element/SspElementTest.java > PRE-CREATION > plugins/pom.xml 2efa248 > setup/db/db/schema-410to420.sql e081a25 > > Diff: https://reviews.apache.org/r/11540/diff/ > > > Testing > ------- > > Some unit test code included, and those run successfully. The plugin command > run successfully on management server. > > > Thanks, > > Hiroaki Kawai > >
