----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9818/#review22578 -----------------------------------------------------------
Roxanne, thanks for working on the patch and resubmitting! Since the storage subsystem has been revamped the secondary storage does not show in Alert state anymore, I will mark this patch as discarded for now. - Prasanna Santhanam On June 19, 2013, 6:50 a.m., roxanne chang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9818/ > ----------------------------------------------------------- > > (Updated June 19, 2013, 6:50 a.m.) > > > Review request for cloudstack, Abhinandan Prateek, edison su, and Nitin Mehta. > > > Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-1594 > > > Repository: cloudstack-git > > > Description > ------- > > Bugfix CLOUDSTACK-1594: Secondary storage host always remains Alert status > [https://issues.apache.org/jira/browse/CLOUDSTACK-1594] > > In file SecondarySotrageManagerImpl.java, function generateSetupCommand, if > the host type is Secondary storage VM, the logic is to set secondarystorage > host, at this time, secondarystorage host stauts should become Up. > > The secondary storage host always remains Alert status, because before the > secondary storage vm is deployed, the secondary storage host is created. The > tricky way (in the end of file AgentManagerImpl.java, function > NotifiMonitorsOfConnection) will try to disconnect secondary storage, > therefore the secondary storage host becomes Alert status. The code should > take SSVM into consider, not only Answer reponse. > > File ResourceManagerImpl.java, function discoverHostsFull, in the end will > call discoverer.postDiscovery, in file > SecondarySotrageDiscover.postDiscovery, the condition _userServiceVM is not > needed since its use to make secondary storage host wait for SSVM is already > done in SecondaryStorageManagerImpl. This makes why secondary storage host > always remains Alert status. > > > Diffs > ----- > > server/src/com/cloud/agent/manager/AgentManagerImpl.java 6baeecf > server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java > c343286 > > services/secondary-storage/src/org/apache/cloudstack/storage/resource/SecondaryStorageDiscoverer.java > d3af792 > > Diff: https://reviews.apache.org/r/9818/diff/ > > > Testing > ------- > > Test 4.0.0, 4.2.0 in basic mode, works well. > > > Thanks, > > roxanne chang > >
