----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11238/#review20779 -----------------------------------------------------------
Commit 7ea2c950f5c1c2446ae94087d7f78812cc94a658 in branch refs/heads/vmsync from Prasanna Santhanam <t...@apache.org> [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=7ea2c95 ] CLOUDSTACK-2554: Ensuring that we honor hypervisor xen's memory constraints When setting memory constraints on Xen guests we should honor: static-min <= dynamic-min <= dynamic-max <= static-max Our VmSpec while allows the guests to like between dynamic-min and dynamic-max the memory set by the resource set the static min to be equal to the dynamic max. This restricts the hypervisor from ensuring optimized memory handling of guests. see: http://wiki.xen.org/wiki/XCP_FAQ_Dynamic_Memory_Control#How_does_XCP_choose_targets_for_guests_in_dynamic_range_mode.3F Another fix was related the restrict_dmc option. when enabled (true) this option disallows scaling a vm. The logic was reverse handled allowing scaling when restrict_dmc was on. This control flow is now fixed. Signed-off-by: Prasanna Santhanam <t...@apache.org> - ASF Subversion and Git Services On May 20, 2013, 1:46 p.m., Prasanna Santhanam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11238/ > ----------------------------------------------------------- > > (Updated May 20, 2013, 1:46 p.m.) > > > Review request for cloudstack and Chip Childers. > > > Description > ------- > > CLOUDSTACK-2554: CloudStack fails to load XCP 1.6 hypervisors > > Missing default constructor fails the agent manager reloading the XCP > resource on reboot of management server. This is fixed by using the > default constructor as do other Xen resources and include a new resource > ala XenServers for XCP1.6. > > Signed-off-by: Prasanna Santhanam <t...@apache.org> > (cherry picked from commit 806aeb990d28179ff532e97dbf64f87cd3d5ca34) > > Conflicts: > > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServerResource.java > > Signed-off-by: Prasanna Santhanam <t...@apache.org> > > > This addresses bug CLOUDSTACK-2554. > > > Diffs > ----- > > > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/discoverer/XcpServerDiscoverer.java > 04982a5 > > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixHelper.java > 52641f6 > > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServer16Resource.java > PRE-CREATION > > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServerResource.java > e4fc9ef > > Diff: https://reviews.apache.org/r/11238/diff/ > > > Testing > ------- > > This was tested against the build from master with the BVT across xen 6.0.2, > kvm and xcp 1.6. > > > Thanks, > > Prasanna Santhanam > >
