----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11238/#review20778 -----------------------------------------------------------
Commit 85d54cd1c088997dd08f0328984bee1a55703636 in branch refs/heads/vmsync from Prasanna Santhanam <t...@apache.org> [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=85d54cd ] CLOUDSTACK-2554: Incorrect compute of minmemory and cpu 23e54bb0 introduced multiple hypervisors support for cpu and memory overcommit. Here the HypervisorGuru base which determines the min, max range for the memory for all hypervisors computes the minCpu using the MemoryOverCommit ratio and minMemory using the CpuOverCommit ratio. Minor typo/logic issue but massive damage across all HV if enabled ;) Signed-off-by: Prasanna Santhanam <t...@apache.org> - ASF Subversion and Git Services On May 20, 2013, 1:46 p.m., Prasanna Santhanam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11238/ > ----------------------------------------------------------- > > (Updated May 20, 2013, 1:46 p.m.) > > > Review request for cloudstack and Chip Childers. > > > Description > ------- > > CLOUDSTACK-2554: CloudStack fails to load XCP 1.6 hypervisors > > Missing default constructor fails the agent manager reloading the XCP > resource on reboot of management server. This is fixed by using the > default constructor as do other Xen resources and include a new resource > ala XenServers for XCP1.6. > > Signed-off-by: Prasanna Santhanam <t...@apache.org> > (cherry picked from commit 806aeb990d28179ff532e97dbf64f87cd3d5ca34) > > Conflicts: > > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServerResource.java > > Signed-off-by: Prasanna Santhanam <t...@apache.org> > > > This addresses bug CLOUDSTACK-2554. > > > Diffs > ----- > > > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/discoverer/XcpServerDiscoverer.java > 04982a5 > > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixHelper.java > 52641f6 > > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServer16Resource.java > PRE-CREATION > > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServerResource.java > e4fc9ef > > Diff: https://reviews.apache.org/r/11238/diff/ > > > Testing > ------- > > This was tested against the build from master with the BVT across xen 6.0.2, > kvm and xcp 1.6. > > > Thanks, > > Prasanna Santhanam > >
