> On May 9, 2013, 6:54 p.m., Sheng Yang wrote: > > vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java, > > line 746 > > <https://reviews.apache.org/r/11019/diff/1/?file=289105#file289105line746> > > > > Reason to remove type converting? > > Venkata Siva Vijayendra Bhamidipati wrote: > Again, eclipse generated, but why would we need that cast? I would remove > it.
The original value is int, and the maximum of int is 2,147,483,647, in other word, the maximum bandwidth here would be 2G, then overflow. That's why you need convert it to long type here. > On May 9, 2013, 6:54 p.m., Sheng Yang wrote: > > vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java, > > line 485 > > <https://reviews.apache.org/r/11019/diff/1/?file=289105#file289105line485> > > > > better using e.g. secondary vlan id. pvlanid is confusing. > > Venkata Siva Vijayendra Bhamidipati wrote: > I'll change that to isolatedpvlanid, should be clearer that way. Could you check if it's possible to represent a community secondary vlan in the future? If so, we'd better name it e.g. secondary pvlan. - Sheng ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11019/#review20387 ----------------------------------------------------------- On May 9, 2013, 7:09 p.m., Venkata Siva Vijayendra Bhamidipati wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11019/ > ----------------------------------------------------------- > > (Updated May 9, 2013, 7:09 p.m.) > > > Review request for cloudstack, Chip Childers, Sheng Yang, Sateesh > Chodapuneedi, Kelven Yang, and Animesh Chaturvedi. > > > Description > ------- > > Please find attached the diffs for pvlan support for vmware DVSwitch > deployments on cloudstack. You will find two diffs - the parent diff is > Sateesh's fix for CLOUSTACK-2316 which is needed to be cherry-picked on the > pvlan branch from the master. The other diff contains the changes for pvlan > support. > > These diffs do not contain changes for pvlan provisioning on the Cisco Nexus > 1000v distributed virtual switch. > > > This addresses bug CLOUDSTACK-1456. > > > Diffs > ----- > > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java > 99ad1ca > server/src/com/cloud/network/NetworkManagerImpl.java 7a09eb5 > server/src/com/cloud/network/NetworkModelImpl.java bd62886 > server/src/com/cloud/vm/UserVmManagerImpl.java 683f0da > server/src/com/cloud/vm/VirtualMachineManagerImpl.java b0d6378 > > vmware-base/src/com/cloud/hypervisor/vmware/mo/DistributedVirtualSwitchMO.java > 247be2a > vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java > 7f323c5 > > Diff: https://reviews.apache.org/r/11019/diff/ > > > Testing > ------- > > The code has been tested on the Vmware DVSwitch for advanced shared networks > on vmware cluster deployments on cloudstack. Unit tests will be the same as > those provided by Sheng as part of the overall PVLAN support for XenServer > and KVM, and will exercise the vmware pvlan code path when user VMs are > created with vNICs sitting on advanced shared networks that have the optional > Private VLAN value set during their creation. VM live migration using vmware > vMotion has also been tested with these changes on vmware and it works as > expected. > > Further testing will be carried out and this review request will be updated > accordingly. > > > Thanks, > > Venkata Siva Vijayendra Bhamidipati > >
