----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11019/#review20387 -----------------------------------------------------------
server/src/com/cloud/network/NetworkModelImpl.java <https://reviews.apache.org/r/11019/#comment41965> What's this for? server/src/com/cloud/vm/UserVmManagerImpl.java <https://reviews.apache.org/r/11019/#comment41966> Can VMware just ignore the command? Rather than put hypervisor specific code here. server/src/com/cloud/vm/VirtualMachineManagerImpl.java <https://reviews.apache.org/r/11019/#comment41967> What's the change in this file for? Not used anywhere. vmware-base/src/com/cloud/hypervisor/vmware/mo/DistributedVirtualSwitchMO.java <https://reviews.apache.org/r/11019/#comment41972> I am confused by pvlanid existed with vlanid here. Do you mean "isolated pvlan"(which is secondary vlan)? vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java <https://reviews.apache.org/r/11019/#comment41973> better using e.g. secondary vlan id. pvlanid is confusing. vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java <https://reviews.apache.org/r/11019/#comment41974> Reason to remove type converting? - Sheng Yang On May 9, 2013, 5:47 p.m., Venkata Siva Vijayendra Bhamidipati wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11019/ > ----------------------------------------------------------- > > (Updated May 9, 2013, 5:47 p.m.) > > > Review request for cloudstack, Chip Childers, Sateesh Chodapuneedi, Kelven > Yang, and Animesh Chaturvedi. > > > Description > ------- > > Please find attached the diffs for pvlan support for vmware DVSwitch > deployments on cloudstack. You will find two diffs - the parent diff is > Sateesh's fix for CLOUSTACK-2316 which is needed to be cherry-picked on the > pvlan branch from the master. The other diff contains the changes for pvlan > support. > > These diffs do not contain changes for pvlan provisioning on the Cisco Nexus > 1000v distributed virtual switch. > > > This addresses bug CLOUDSTACK-1456. > > > Diffs > ----- > > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java > 99ad1ca > server/src/com/cloud/network/NetworkManagerImpl.java 7a09eb5 > server/src/com/cloud/network/NetworkModelImpl.java bd62886 > server/src/com/cloud/vm/UserVmManagerImpl.java 683f0da > server/src/com/cloud/vm/VirtualMachineManagerImpl.java b0d6378 > > vmware-base/src/com/cloud/hypervisor/vmware/mo/DistributedVirtualSwitchMO.java > 247be2a > vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java > 7f323c5 > > Diff: https://reviews.apache.org/r/11019/diff/ > > > Testing > ------- > > The code has been tested on the Vmware DVSwitch for advanced shared networks > on vmware cluster deployments on cloudstack. Unit tests will be the same as > those provided by Sheng as part of the overall PVLAN support for XenServer > and KVM, and will exercise the vmware pvlan code path when user VMs are > created with vNICs sitting on advanced shared networks that have the optional > Private VLAN value set during their creation. VM live migration using vmware > vMotion has also been tested with these changes on vmware and it works as > expected. > > Further testing will be carried out and this review request will be updated > accordingly. > > > Thanks, > > Venkata Siva Vijayendra Bhamidipati > >
