+1 to set dismiss_stale_reviews: false. On Thu, Jan 16, 2025 at 11:03 PM Dianjin Wang <wangdian...@gmail.com> wrote:
> +1 to set dismiss_stale_reviews: false. > > Best, > Dianjin Wang > > > On Fri, Jan 17, 2025 at 2:10 PM Ed Espino <eesp...@gmail.com> wrote: > > > Hi Dianjin, > > > > Thank you for explaining the dismiss_stale_reviews option in the > .asf.yaml > > file. Since we are running on GitHub, I believe we can leverage GitHub’s > > built-in capabilities to track changes and ensure a smooth review > process. > > > > GitHub automatically captures and displays all changes between the PR > > branch and its target branch, even after updates like rebases or force > > pushes. Reviewers and committers can use the *Files Changed* tab to see > the > > latest state of the PR and evaluate updates efficiently. > > > > To address concerns about maintaining quality after a PR is updated: > > > > 1. GitHub Actions already reruns CI pipelines for any new changes, > > ensuring that updates are validated against our standards. > > 2. Committers merging the PR can take a final pass through the changes > > to verify that everything looks correct. > > > > I propose we trial setting dismiss_stale_reviews: false in the .asf.yaml > > file to simplify the review process and reduce repetitive approvals. If > > this approach introduces any issues or inefficiencies, we can revisit the > > setting and adjust our workflow accordingly. > > > > Looking forward to your feedback! > > > > Best regards, > > -=e > > > -- Ed Espino Apache Cloudberry (incubating) & MADlib
