Sounds reasonable in some cases. Is it possible to add a special CI skip cancel instruction if author don't want to cancel APPROVE?
On Thu, Jan 16, 2025 at 5:42 PM jiaqi.zhou <jiaqi...@163.com> wrote: > Hi all, > > > I personally have an idea: we should not cancel approve after PR has been > updated. > > > 1. After the reviewer approves the PR, the current PR may still need to be > rebased (do git rebase main or git merge main) > 2. The approved PR will still run CI once to ensure that the current PR is > compliant > 3. If the PR is updated, the reviewer needs to approve it again, which > wastes the time of both the committer and the reviewer. > > > For example:the reviewer made some minor comments (such as suggestions for > changing some typo, or the comments that can be rejected) and approved > current PR. The commiter accepted these suggestions and update the PR. > After that, reviewer still need click the approve button again (or may need > to review the PR again). I think this is unreasonable. > > > Thanks > Jiaqi > > > > > >
