opencirclesolutions-wove commented on code in PR #2412:
URL: https://github.com/apache/causeway/pull/2412#discussion_r1611596262
##########
extensions/security/audittrail/applib/src/main/java/org/apache/causeway/extensions/audittrail/applib/dom/AuditTrailEntryRepositoryAbstract.java:
##########
@@ -60,12 +63,25 @@ public Class<E> getEntityClass() {
return auditTrailEntryClass;
}
+ @Override
public AuditTrailEntry createFor(final EntityPropertyChange change) {
E entry = factoryService.detachedEntity(auditTrailEntryClass);
entry.init(change);
return repositoryService.persistAndFlush(entry);
}
+ @Override
+ public Can<AuditTrailEntry> createForBulk(Can<EntityPropertyChange>
entityPropertyChanges) {
+ Collection<AuditTrailEntry> auditTrailEntries =
repositoryService.execInBulk(() -> entityPropertyChanges.stream()
Review Comment:
You can call the super of an implemented interface even when it’s a default.
But this will do just fine:
return Can.ofCollection(repositoryService.execInBulk(() ->
entityPropertyChanges.map(this::createFor).toList()));
##########
persistence/commons/src/main/java/org/apache/causeway/persistence/commons/integration/repository/RepositoryServiceDefault.java:
##########
@@ -78,6 +83,7 @@ public class RepositoryServiceDefault
@Getter(onMethod_ = {@Override})
final MetaModelContext metaModelContext;
+ private ThreadLocal<Map<Class, Boolean>> threadLocal =
ThreadLocal.withInitial(HashMap::new);
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@causeway.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
