opencirclesolutions-wove commented on code in PR #2412:
URL: https://github.com/apache/causeway/pull/2412#discussion_r1611570240


##########
persistence/commons/src/main/java/org/apache/causeway/persistence/commons/integration/repository/RepositoryServiceDefault.java:
##########
@@ -120,7 +147,9 @@ public <T> T persist(final T domainObject) {
     @Override
     public <T> T persistAndFlush(final T object) {
         persist(object);
-        transactionService.flushTransaction();
+        if (!threadLocal.get().getOrDefault(object.getClass(), Boolean.FALSE)) 
{

Review Comment:
   Good point. The idea was to have more fine grain control over which classes 
you wanted to persist with or without a flush. But in bulk mode you want to 
have everything in one transaction. Everything else so have its own transaction 
or even thread.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@causeway.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to