Reading this a week later, just wanted to point out that this discussion already shows that releasing an alpha1 now was/is a good idea. It immediately helped attract attention from a wider group of people, and we can now address these issues with less stress than if all features were already done, or there is an upcoming conference, or thanksgiving Holiday or Christmas...
People often forget that the release machinery itself is a complex technical system that very rarely "just works" when once a year you change branches and version numbers... And thanks Justin for such a pedantic review so early in our process. Very helpful and convenient! henrik On Tue, Aug 29, 2023 at 5:59 AM Justin Mclean <jmcl...@apache.org> wrote: > Hi, > > If I were to vote on this, it would be -1 (non-binding) due to > non-compliance with ASF policy on releases. > > I checked: > - signatures and hashes are correct > - It looks like there might be compiled code in the release? [1][2] > - LICENSE is misisng some 3rd party code license information [5] This > contains code "Copyright DataStax, Inc." under ALv2, python-smhasher under > MIT, OrderedDict under MIT (copyright Raymond Hettinger) and code from > MagnetoDB under ALv2. > - LICENSE has no mention of 3rd party CRC code in [10] > - Note that any code under CC 4.0 is incompatible with the ALv2. [11] > - LICENSE also doesn't mention this file [9] > - In LICENSE LongTimSort.java incorrectly mentions two different copyright > owners > - In LICENSE, AbstractGuavaIterator.java is incorrectly mentioned as > AbstractIterator.java > - NOTICE seems OK but may also be missing some things due to misisng 3rd > party code in LICENSE under ALv2 > - Files are misisng ASF headers [3][4][6][7][8] are these 3rd party files? > - I didn't try compiling from the source > > Kind Regards, > Justin > > 1../test/data/serialization/3.0/utils.BloomFilter1000.bin > 2. ./test/data/serialization/4.0/utils.BloomFilter1000.bin > 3. ./doc/modules/cassandra/examples/BASH/*.sh > 4. ./pylib/Dockerfile.ubuntu.* > 5. ./lib/cassandra-driver-internal-only-3.25.0.zip > 6. ./lib/cassandra-driver-3.25.0/cassandra/murmur3.py > 7. ./lib/cassandra-driver-3.25.0/cassandra/io/asyncioreactor.py > 8 ./lib/cassandra-driver-3.25.0/cassandra/io/libevwrapper.c > 9. ./tools/fqltool/src/org/apache/cassandra/fqltool/commands/Dump.java > 10. ./src/java/org/apache/cassandra/net/Crc.java > 11. https://www.apache.org/legal/resolved.html#cc-by > -- Henrik Ingo c. +358 40 569 7354 w. www.datastax.com <https://www.facebook.com/datastax> <https://twitter.com/datastax> <https://www.linkedin.com/company/datastax/> <https://github.com/datastax/>
