I personally use Github PRs to discuss the changes if there is feedback on the code. The discussion does get linked with the JIRA ticket. However, committing is manual.
Dinesh > On Jan 22, 2020, at 2:20 PM, David Capwell <dcapw...@gmail.com> wrote: > > When submitting or reviewing a change in JIRA I notice that we have three > main patterns for doing this: link branch, link diff, and link GitHub pull > request (PR); I wanted to bring up the idea of switching over to GitHub > pull requests as the norm. > > > Why should we do this? The main reasons I can think of are: consistency > within the project, common pattern outside and inside Apache (not a new > process for new members to learn), > > PRs are easier to review and comment on (much easier than linking lines in > a branch), Github and JIRA integration is already present so all > conversations will be added to the JIRA work log, and could be linked with > Jenkins to trigger builds and tests and to report the status into JIRA. > > > How would one start to do this? > > > > 1. Include the JIRA link in a commit message (example: > CASSANDRA-<number> : message) > 2. Create pull request (when creating the branch, the git message > provides a link to create a pull request) > > > That is it, by doing those two steps JIRA will be updated with all Github > conversations, Jenkins could be notified and start building and report back > to JIRA. > > > Thoughts? > > > References: > > - https://www.apache.org/dev/svngit2jira.html --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org For additional commands, e-mail: dev-h...@cassandra.apache.org
