>> I think it goes the other way around. When you push to ASF git with the right commit message then the integration from that side closes the pull request.
Yes. This is how apache-gossip is setup. Someone makes a JIRA and they include a link to there branch and tell me they are done. We review git checkout apache master git pull otherperson jira-123 git push origin master Ticket on github is "magically" closed. On Mon, Aug 29, 2016 at 8:45 AM, J. D. Jordan <jeremiah.jor...@gmail.com> wrote: > I think it goes the other way around. When you push to ASF git with the > right commit message then the integration from that side closes the pull > request. > > > On Aug 28, 2016, at 11:48 PM, Jonathan Ellis <jbel...@gmail.com> wrote: > > > > Don't we need something on the infra side to turn a merged pull request > > into a commit to the ASF repo? > > > > On Sun, Aug 28, 2016 at 11:07 PM, Nate McCall <n...@thelastpickle.com> > > wrote: > > > >>> > >>> > >>> Infra is exploring options for giving PMCs greater control over GitHub > >>> config (including allowing GitHub to be the master with a golden copy > >>> held at the ASF) but that is a work in progress. > >> ^ Per Mark's comment, there is not anything we can really do past what > >> Jake F. described with Thrift. We dealt with this with Usergrid back in > >> incubation two years ago (Jake F. actually helped us get it all sorted > at > >> the time) when we were using https://github.com/usergrid/usergrid as > the > >> source: > >> http://mail-archives.apache.org/mod_mbox/usergrid-dev/201405.mbox/% > >> 3CCANyrgvdTVzZQD7w3C96LUHa=h7-h4qmu4h7ajsxoat0gd0f...@mail.gmail.com%3E > >> > >> Here is the Thrift guide again for reference: > >> https://github.com/apache/thrift/blob/master/ > CONTRIBUTING.md#contributing- > >> via-github-pull-requests > >> > >> JClouds also has a nice write up/how-to (we based Usergrid on this, > >> initially): > >> https://cwiki.apache.org/confluence/display/JCLOUDS/Git+workflow > >> > >> Maybe we just amend our 'how-to-commit' with similar details as the two > >> references above? > >> http://cassandra.apache.org/doc/latest/development/how_to_commit.html > >> > >> -Nate > >> > >> On Mon, Aug 29, 2016 at 10:44 AM, Nate McCall <n...@thelastpickle.com> > >> wrote: > >> > >>> > >>>> Nate, since you have experience with this from Usergrid, can you > figure > >>>> out > >>>> what we need to do to make this happen and follow up with infra? > >>> > >>> Yep - i'll look into this. > > > > > > > > -- > > Jonathan Ellis > > Project Chair, Apache Cassandra > > co-founder, http://www.datastax.com > > @spyced >
