It sounds like we have consensus that enabling pull requests would be a Very Good Thing.
Nate, since you have experience with this from Usergrid, can you figure out what we need to do to make this happen and follow up with infra? On Sun, Aug 28, 2016 at 3:07 PM, Nate McCall <n...@thelastpickle.com> wrote: > +1 > > Github PRs have worked well for Usergrid: > https://cwiki.apache.org/confluence/display/usergrid/ > Usergrid+Contribution+Workflow > > > On Sat, Aug 27, 2016 at 4:15 AM, Jake Luciani <jak...@gmail.com> wrote: > > > Jake could you show an example issue and how the pipeline works? > > > > On Fri, Aug 26, 2016 at 12:03 PM, Jake Farrell <jfarr...@apache.org> > > wrote: > > > > > We just switched Apache Thrift over to using Github for all our inbound > > > contributions, have not made Github canonical yet. We wanted to have > one > > > unified way to accept patches and also make it easier for automated CI > to > > > validate the patch prior to review. Much easier now that we have a set > > > pipeline > > > > > > -Jake > > > > > > On Fri, Aug 26, 2016 at 11:44 AM, Ben Coverston < > > > ben.covers...@datastax.com> > > > wrote: > > > > > > > I think it would certainly make contributing to Cassandra more > > > > straightforward. > > > > > > > > I'm not a committer, so I don't regularly create patches, and every > > time > > > I > > > > do I have to search/verify that I'm doing it right. > > > > > > > > But pull requests? I make pull requests every day, and GitHub makes > > that > > > > process work the same everywhere. > > > > > > > > On Fri, Aug 26, 2016 at 9:33 AM, Jonathan Ellis <jbel...@gmail.com> > > > wrote: > > > > > > > > > Hi all, > > > > > > > > > > Historically we've insisted that people go through the process of > > > > creating > > > > > a Jira issue and attaching a patch or linking a branch to > demonstrate > > > > > intent-to-contribute and to make sure we have a unified record of > > > changes > > > > > in Jira. > > > > > > > > > > But I understand that other Apache projects are now recognizing a > > > github > > > > > pull request as intent-to-contribute [1] and some are even making > > > github > > > > > the official repo, with an Apache mirror, rather than the other way > > > > > around. (Maybe this is required to accept pull requests, I am not > > > sure.) > > > > > > > > > > Should we revisit our policy here? > > > > > > > > > > [1] e.g. https://github.com/apache/spark/pulls?q=is%3Apr+is% > 3Aclosed > > > > > > > > > > -- > > > > > Jonathan Ellis > > > > > Project Chair, Apache Cassandra > > > > > co-founder, http://www.datastax.com > > > > > @spyced > > > > > > > > > > > > > > > > > > > > > -- > > > > Ben Coverston > > > > DataStax -- The Apache Cassandra Company > > > > > > > > > > > > > > > -- > > http://twitter.com/tjake > > > > > > -- > ----------------- > Nate McCall > Wellington, NZ > @zznate > > CTO > Apache Cassandra Consulting > http://www.thelastpickle.com > -- Jonathan Ellis Project Chair, Apache Cassandra co-founder, http://www.datastax.com @spyced
