rajvarun77 commented on code in PR #3330:
URL: https://github.com/apache/brpc/pull/3330#discussion_r3511126881
##########
src/brpc/controller.h:
##########
@@ -762,6 +776,10 @@ friend void
policy::ProcessThriftRequest(InputMessageBase*);
// CONNECTION_TYPE_SINGLE. Otherwise, it may be a temporary
// socket fetched from socket pool
SocketUniquePtr sending_sock;
+ // In-class default so every Call init path (default ctor, Reset(), and
+ // the Call(Call*) copy ctor used for backup/retry) is NONE unless set
+ // explicitly. A backup/retry never inherits transaction affinity.
+ BindSockAction bind_sock_action = BIND_SOCK_NONE;
Review Comment:
Done in `530e1124`: `Call::bind_sock_action` is now initialized explicitly
in every constructor (incl. the backup/retry copy ctor), not via an in-class
default. That missing init was the cause of the backup/retry hang. CI green.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
