Thanks Nicolo. > I'd suggest to just disable them at this point
Why would you recommend that? I wonder what has been causing tests to be skipped in the Maven build? In the Junit 5 PR, I have upgraded maven-surefire-plugin and tests get run with Junit 5's vintage engine. Is there a known bug in older maven plugin versions that tests get skipped without notice? -Lari On 2024/02/01 19:38:09 Nicolò Boschi wrote: > Hi Lari, > They haven't run for years now. > > When we migrated to Gradle, I made them to work again. See > https://lists.apache.org/thread/p9twnlh75kp7t74d8ghmtqbw1f5v4kgk > > > But after switching back to Maven, nobody took care of them and no attempts > have been made to make them runnable again > > I'd suggest to just disable them at this point > > Nicolò Boschi > > > Il giorno gio 1 feb 2024 alle ore 20:23 Lari Hotari <lhot...@apache.org> ha > scritto: > > > Hi, > > > > I'm currently working on a PR to enable writing tests with Junit 5 and > > having Junit 5 tests in addition to Junit 4 tests. This is in PR > > https://github.com/apache/bookkeeper/pull/4197 > > > > Suddenly there are test failures! I first thought that the upgrade had > > broken something, but it turns out that my changes fix problems and start > > running tests that were previously ignored! > > > > Previously, integration tests ran in 29 seconds! > > [INFO] > > ------------------------------------------------------------------------ > > [INFO] BUILD SUCCESS > > [INFO] > > ------------------------------------------------------------------------ > > [INFO] Total time: 29.054 s > > [INFO] Finished at: 2024-01-31T02:32:17Z > > [INFO] > > ------------------------------------------------------------------------ > > > > Test current server with old clients: > > [INFO] > > ------------------------------------------------------------------------ > > [INFO] BUILD SUCCESS > > [INFO] > > ------------------------------------------------------------------------ > > [INFO] Total time: 5.464 s > > [INFO] Finished at: 2024-01-31T02:28:31Z > > [INFO] > > ------------------------------------------------------------------------ > > > > The docker container tests using arquillian-cube-docker have been skipped > > completely. I managed to get arquillian-cube-docker to run, but it turns > > out that the build isn't properly setup for this. I guess I put myself in a > > rabbit hole... I need some help. > > > > Could someone share more context about the state of Bookkeeper CI? > > Any ongoing effort to improve it? > > > > Thanks > > > > -Lari > > >
