I did find https://github.com/apache/bookkeeper/pull/2937 where tests were 
fixed for the Gradle build.
My guess is that the tests haven't been running properly since the Gradle build 
was replaced with the old Maven build: 
https://github.com/apache/bookkeeper/pull/3130
I might be wrong since this is a pure guess. :)

-Lari

On 2024/02/01 19:23:39 Lari Hotari wrote:
> Hi,
> 
> I'm currently working on a PR to enable writing tests with Junit 5 and having 
> Junit 5 tests in addition to Junit 4 tests. This is in PR 
> https://github.com/apache/bookkeeper/pull/4197
> 
> Suddenly there are test failures! I first thought that the upgrade had broken 
> something, but it turns out that my changes fix problems and start running 
> tests that were previously ignored!
> 
> Previously, integration tests ran in 29 seconds!
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Total time:  29.054 s
> [INFO] Finished at: 2024-01-31T02:32:17Z
> [INFO] 
> ------------------------------------------------------------------------
> 
> Test current server with old clients:
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Total time:  5.464 s
> [INFO] Finished at: 2024-01-31T02:28:31Z
> [INFO] 
> ------------------------------------------------------------------------
> 
> The docker container tests using arquillian-cube-docker have been skipped 
> completely. I managed to get arquillian-cube-docker to run, but it turns out 
> that the build isn't properly setup for this. I guess I put myself in a 
> rabbit hole... I need some help.
> 
> Could someone share more context about the state of Bookkeeper CI?
> Any ongoing effort to improve it?
> 
> Thanks
> 
> -Lari
> 

Reply via email to