Yong, Il giorno mer 28 set 2022 alle ore 10:23 Yong Zhang <zhangyong1025...@gmail.com> ha scritto: > > We have improved the memory issue with backpressure with PR > https://github.com/apache/bookkeeper/pull/3324 > > The backpressure way can prevent there have too many Add requests > pending to the client and waiting for the response. It makes the add > requests > fail fast, so if the channel is not writable, it will fail the request as > soon as > possible and then release the memory. > > But that depends on the time. If your throughput is very smooth, and you > have enough memory for the bookie client. With backpressure, it would work > fine. > If you have a huge adds to the bookie in a very short time, it acquires a > lot of > memory, then the bookie crashed with OOM. > So we still need this proposal. > > I will continue to work on this. If there haven't objected, I will start a > VOTE later
Thanks Enrico > Thanks, > Yong > > On Thu, 21 Apr 2022 at 19:17, r...@apache.org <ranxiaolong...@gmail.com> > wrote: > > > Hello Yong: > > > > It seems to be a very useful feature. In the production environment, you > > can often see similar phenomena happening. > > > > +1 (non-binding) > > > > -- > > Thanks > > Xiaolong Ran > > > > Yong Zhang <y...@apache.org> 于2022年4月21日周四 18:29写道： > > > > > Hi all, > > > > > > The BP-51 BookKeeper client memory limits is ready for review. > > > The proposal is here: https://github.com/apache/bookkeeper/issues/3231 > > > And the PR is here: https://github.com/apache/bookkeeper/pull/3139 > > > > > > Please help to review this proposal. > > > > > > Thanks! > > > Yong > > > > >
