Hi all, We have upgraded Pravega to Bookkeeper 4.15.0 and the build passes, as well as our system tests (distributed setting): https://github.com/pravega/pravega/pull/6676
We will continue checking for regressions, but assuming the logging issue detected by Enrico is fixed on a new RC, things look good so far. Thanks, Raúl. Internal Use - Confidential -----Original Message----- From: Andrey Yegorov <andrey.yego...@datastax.com> Sent: martes, 5 de abril de 2022 21:04 To: dev@bookkeeper.apache.org Subject: Re: [VOTE] Release 4.15.0, release candidate #0 [EXTERNAL EMAIL] Hi, I don't think multi-core build with maven is a blocker, I don't think it ever worked. But I agree with Enrico that the log4j v2 is a blocker, I looked at te problem a bit more, my comment on this: https://urldefense.com/v3/__https://github.com/apache/bookkeeper/pull/3148*issuecomment-1089196546__;Iw!!LpKI!x34AeYuxtdyF8xLLQfwa6FqUTieMrO9QAV5SLg-T_tPlzHfYy4wgOFcoKAF_pCA$ [github[.]com] On Fri, Apr 1, 2022 at 9:08 PM Hang Chen <chenh...@apache.org> wrote: > Hi Andrey, > I download the source code and build it by multi cpu cores, it > failed occasionally. I opened an issue to track it. > https://urldefense.com/v3/__https://github.com/apache/bookkeeper/issues/3174__;!!LpKI!x34AeYuxtdyF8xLLQfwa6FqUTieMrO9QAV5SLg-T_tPlzHfYy4wgOFcoPJTTcAQ$ > [github[.]com] > It maybe an old issue, and it is not the blocker for this release. > > Thanks, > Hang > > Andrey Yegorov <andrey.yego...@datastax.com> 于2022年4月1日周五 23:02写道： > > > > ok, please cherry-pick or label PRs to cherry-pick into the release, > > we'll have to go through RC1. > > I tried upgrading Pulsar and enountered breaking changes listed here: > > > https://urldefense.com/v3/__https://github.com/apache/bookkeeper/pull/ > 3155/files*diff-eff52edf7022fd953f60c68061de09ec5d148eb37893de6af85a79 > 64a2e57855__;Iw!!LpKI!x34AeYuxtdyF8xLLQfwa6FqUTieMrO9QAV5SLg-T_tPlzHfY > y4wgOFcoP3naHHs$ [github[.]com] > > I'll look at the ways to simplify upgrade but making it simply a > dependency > > change might not be possible. > > > > On Fri, Apr 1, 2022 at 5:40 AM Enrico Olivelli <eolive...@gmail.com> > wrote: > > > > > -1 > > > I have run the tests and a few smoke tests and everything is passing. > > > > > > But unfortunately the Bookie is not logging anymore due to the > > > switch > to > > > log4j2 > > > > > > I have tracked the problem here > > > https://urldefense.com/v3/__https://github.com/apache/bookkeeper/i > > > ssues/3165__;!!LpKI!x34AeYuxtdyF8xLLQfwa6FqUTieMrO9QAV5SLg-T_tPlzH > > > fYy4wgOFcoYcET3jM$ [github[.]com] > > > > > > > > > Not blocker for a release: > > > I should also note that upgrading downstream applications that run > > > the Bookie from Java code is quite hard I tried to upgrade these > > > projects: > > > - HerdDB: > > > https://urldefense.com/v3/__https://github.com/diennea/herddb/pull > > > /784__;!!LpKI!x34AeYuxtdyF8xLLQfwa6FqUTieMrO9QAV5SLg-T_tPlzHfYy4wg > > > OFco2iaRQlo$ [github[.]com] > > > - Pravega.io: > > > https://urldefense.com/v3/__https://github.com/pravega/pravega/pul > > > l/6669__;!!LpKI!x34AeYuxtdyF8xLLQfwa6FqUTieMrO9QAV5SLg-T_tPlzHfYy4 > > > wgOFcoMLXIP7g$ [github[.]com] Same problem: the BookieServer > > > constructor changed, and the structure of the Bookie changed a lot > > > (when we switched to Bookie to be a interface and created > > > BookieImpl) I didn't try to upgrade Apache Pulsar, but I guess the > > > problem will be > the > > > same > > > > > > I am also aware of other non-OSS projects that start the Bookie > > > using Java in order to run unit tests > > > > > > It may make sense to create a BookieService utility class to > > > bootstrap the Bookie from Java as many projects do. > > > > > > > > > Enrico > > > > > > > > > Il giorno mer 30 mar 2022 alle ore 01:33 Andrey Yegorov > > > <andrey.yego...@datastax.com> ha scritto: > > > > > > > > Hi everyone, > > > > Please review and vote on the release candidate #0 for the > > > > version > > > 4.15.0, > > > > as follows: > > > > [ ] +1, Approve the release > > > > [ ] -1, Do not approve the release (please provide specific > > > > comments) > > > > > > > > The complete staging area is available for your review, which > includes: > > > > * Release notes [1] > > > > * The official Apache source and binary distributions to be > > > > deployed > to > > > > dist.apache.org [2] > > > > * All artifacts to be deployed to the Maven Central Repository > > > > [3] > > > > * Source code tag "release-4.15.0" [4] with git sha > > > > 9e2db102fe0dc9340f405a3afeacd2ef94359564 > > > > > > > > BookKeeper's KEYS file contains PGP keys we used to sign this > release: > > > > https://urldefense.com/v3/__https://dist.apache.org/repos/dist/r > > > > elease/bookkeeper/KEYS__;!!LpKI!x34AeYuxtdyF8xLLQfwa6FqUTieMrO9Q > > > > AV5SLg-T_tPlzHfYy4wgOFcobIiNbXk$ [dist[.]apache[.]org] > > > > > > > > Please download these packages and review this release candidate: > > > > > > > > - Review release notes > > > > - Download the source package (verify shasum, and asc) and > > > > follow the instructions to build and run the bookkeeper service. > > > > - Download the binary package (verify shasum, and asc) and > > > > follow the instructions to run the bookkeeper service. > > > > - Review maven repo, release tag, licenses, and any other things > > > > you > > > think > > > > it is important to a release. > > > > > > > > The vote will be open for at least 72 hours. It is adopted by > majority > > > > approval, with at least 3 PMC affirmative votes. > > > > > > > > Thanks, > > > > Release Manager > > > > > > > > [1] > > > > > > > > https://urldefense.com/v3/__https://github.com/apache/bookkeeper/pull/ > 3155/files*diff-eff52edf7022fd953f60c68061de09ec5d148eb37893de6af85a79 > 64a2e57855__;Iw!!LpKI!x34AeYuxtdyF8xLLQfwa6FqUTieMrO9QAV5SLg-T_tPlzHfY > y4wgOFcoP3naHHs$ [github[.]com] > > > > [2] > > > > https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/boo > kkeeper/bookkeeper-4.15.0-rc0/__;!!LpKI!x34AeYuxtdyF8xLLQfwa6FqUTieMrO > 9QAV5SLg-T_tPlzHfYy4wgOFcoZcGawa0$ [dist[.]apache[.]org] > > > > [3] > > > > > > > > https://urldefense.com/v3/__https://repository.apache.org/content/repo > sitories/orgapachebookkeeper-1063/__;!!LpKI!x34AeYuxtdyF8xLLQfwa6FqUTi > eMrO9QAV5SLg-T_tPlzHfYy4wgOFcoEqWqU5g$ [repository[.]apache[.]org] > > > > [4] > > > > https://urldefense.com/v3/__https://github.com/apache/bookkeeper > > > > /releases/tag/v4.15.0-rc0__;!!LpKI!x34AeYuxtdyF8xLLQfwa6FqUTieMr > > > > O9QAV5SLg-T_tPlzHfYy4wgOFcowC17ziM$ [github[.]com] > > > > > > > > -- > > > > Andrey Yegorov > > > > > > > > > -- > > Andrey Yegorov > -- Andrey Yegorov Dell Computer SAU - C.I.F. A-80022734, Inscrita en el Registro Mercantil de Madrid, Tomo 1108, Folio 199, Hoja M-21115, y domicilio en Calle Ribera Del Loira n8, Paris Building, 28042, Madrid, España Número de inscripción Registro REI-RAEE: 000496.
