Hi, I don't think multi-core build with maven is a blocker, I don't think it ever worked.
But I agree with Enrico that the log4j v2 is a blocker, I looked at te problem a bit more, my comment on this: https://github.com/apache/bookkeeper/pull/3148#issuecomment-1089196546 On Fri, Apr 1, 2022 at 9:08 PM Hang Chen <chenh...@apache.org> wrote: > Hi Andrey, > I download the source code and build it by multi cpu cores, it > failed occasionally. I opened an issue to track it. > https://github.com/apache/bookkeeper/issues/3174 > It maybe an old issue, and it is not the blocker for this release. > > Thanks, > Hang > > Andrey Yegorov <andrey.yego...@datastax.com> 于2022年4月1日周五 23:02写道： > > > > ok, please cherry-pick or label PRs to cherry-pick into the release, > > we'll have to go through RC1. > > I tried upgrading Pulsar and enountered breaking changes listed here: > > > https://github.com/apache/bookkeeper/pull/3155/files#diff-eff52edf7022fd953f60c68061de09ec5d148eb37893de6af85a7964a2e57855 > > I'll look at the ways to simplify upgrade but making it simply a > dependency > > change might not be possible. > > > > On Fri, Apr 1, 2022 at 5:40 AM Enrico Olivelli <eolive...@gmail.com> > wrote: > > > > > -1 > > > I have run the tests and a few smoke tests and everything is passing. > > > > > > But unfortunately the Bookie is not logging anymore due to the switch > to > > > log4j2 > > > > > > I have tracked the problem here > > > https://github.com/apache/bookkeeper/issues/3165 > > > > > > > > > Not blocker for a release: > > > I should also note that upgrading downstream applications that run the > > > Bookie from Java code is quite hard > > > I tried to upgrade these projects: > > > - HerdDB: https://github.com/diennea/herddb/pull/784 > > > - Pravega.io: https://github.com/pravega/pravega/pull/6669 > > > Same problem: the BookieServer constructor changed, and the structure > > > of the Bookie changed a lot (when we switched to Bookie to be a > > > interface and created BookieImpl) > > > I didn't try to upgrade Apache Pulsar, but I guess the problem will be > the > > > same > > > > > > I am also aware of other non-OSS projects that start the Bookie using > > > Java in order to run unit tests > > > > > > It may make sense to create a BookieService utility class to bootstrap > > > the Bookie from Java as many projects do. > > > > > > > > > Enrico > > > > > > > > > Il giorno mer 30 mar 2022 alle ore 01:33 Andrey Yegorov > > > <andrey.yego...@datastax.com> ha scritto: > > > > > > > > Hi everyone, > > > > Please review and vote on the release candidate #0 for the version > > > 4.15.0, > > > > as follows: > > > > [ ] +1, Approve the release > > > > [ ] -1, Do not approve the release (please provide specific comments) > > > > > > > > The complete staging area is available for your review, which > includes: > > > > * Release notes [1] > > > > * The official Apache source and binary distributions to be deployed > to > > > > dist.apache.org [2] > > > > * All artifacts to be deployed to the Maven Central Repository [3] > > > > * Source code tag "release-4.15.0" [4] with git > > > > sha 9e2db102fe0dc9340f405a3afeacd2ef94359564 > > > > > > > > BookKeeper's KEYS file contains PGP keys we used to sign this > release: > > > > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS > > > > > > > > Please download these packages and review this release candidate: > > > > > > > > - Review release notes > > > > - Download the source package (verify shasum, and asc) and follow the > > > > instructions to build and run the bookkeeper service. > > > > - Download the binary package (verify shasum, and asc) and follow the > > > > instructions to run the bookkeeper service. > > > > - Review maven repo, release tag, licenses, and any other things you > > > think > > > > it is important to a release. > > > > > > > > The vote will be open for at least 72 hours. It is adopted by > majority > > > > approval, with at least 3 PMC affirmative votes. > > > > > > > > Thanks, > > > > Release Manager > > > > > > > > [1] > > > > > > > > https://github.com/apache/bookkeeper/pull/3155/files#diff-eff52edf7022fd953f60c68061de09ec5d148eb37893de6af85a7964a2e57855 > > > > [2] > > > > https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.15.0-rc0/ > > > > [3] > > > > > > > > https://repository.apache.org/content/repositories/orgapachebookkeeper-1063/ > > > > [4] https://github.com/apache/bookkeeper/releases/tag/v4.15.0-rc0 > > > > > > > > -- > > > > Andrey Yegorov > > > > > > > > > -- > > Andrey Yegorov > -- Andrey Yegorov
