+1 (binding) Verified checksums and signatures. Built from sources with JDK13 on MacOs. Run tests on JDK8 + MacOs, tests are passing.
Unit tests of HerdDB are passing: - I had a little problem in understanding how PlacementPolicyAdherence works - it is actually a nuisance that we are breaking PlacementPolicy APIs at every major release, but we already discussed this and I can live with it) I have found a little issue in the new package bkctl, as we are not creating the directory "logs" the first time you run the tool you will see an error (with JDK11+). https://github.com/apache/bookkeeper/issues/2197 Personally I also find it annoying that by default the output of the tool is in "logs" and on stdout, it is very confusing for the user. I did not create an issue for this fact. Maybe it is better to start a discussion in a separate thread. Enrico Il giorno mar 5 nov 2019 alle ore 14:32 Jia Zhai <zhaiji...@gmail.com> ha scritto: > +1 (binding) > > Environment: macOS 10.14.2 > > - verified packages checksum and signatures. > > - the source package build and test all run successfully. > > - in both binary package(server & all), 'bin/bookkeeper standalone' and > 'bin/bookkeeper shell bookiesanity' runs well. > > > Jia Zhai > > Beijing, China > > Mobile: +86 15810491983 > > > > > On Mon, Nov 4, 2019 at 1:52 PM Sijie Guo <guosi...@gmail.com> wrote: > > > +1 (binding) > > > > - verified signatures, shasum > > - build the source > > - binary can run > > - tag is good > > - release note is good. > > > > On Thu, Oct 31, 2019 at 7:46 PM Enrico Olivelli <eolive...@gmail.com> > > wrote: > > > > > Hi everyone, > > > Please review and vote on the release candidate #0 for the version > > 4.10.0, > > > as follows: > > > [ ] +1, Approve the release > > > [ ] -1, Do not approve the release (please provide specific comments) > > > > > > The complete staging area is available for your review, which includes: > > > * Release notes [1] > > > * The official Apache source and binary distributions to be deployed to > > > dist.apache.org [2] > > > * All artifacts to be deployed to the Maven Central Repository [3] > > > * Source code tag "v4.10.0-rc0" [4] with git sha > > > 2f08377f5c56f96389fb3a8e51844844537e118b > > > > > > BookKeeper's KEYS file contains PGP keys we used to sign this release: > > > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS > > > > > > Please download these packages and review this release candidate: > > > > > > - Review release notes > > > - Download the source package (verify shasum, and asc) and follow the > > > instructions to build and run the bookkeeper service. > > > - Download the binary package (verify shasum, and asc) and follow the > > > instructions to run the bookkeeper service. > > > - Review maven repo, release tag, licenses, and any other things you > > think > > > it is important to a release. > > > > > > The vote will be open for at least 72 hours. It is adopted by majority > > > approval, with at least 3 PMC affirmative votes. > > > > > > Thanks, > > > Enrico Olivelli > > > > > > [1] > > > > > > > > > https://github.com/apache/bookkeeper/pull/2165/commits/0d91a95f306031d85c6a8195b0e6d73523cbfc0a > > > [2] > > > > https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.10.0-rc0/ > > > [3] > > > > > > > > > https://repository.apache.org/content/repositories/orgapachebookkeeper-1043/ > > > [4] https://github.com/apache/bookkeeper/tree/v4.10.0-rc0 > > > > > >
