It's ok for me. +1 (non-binding)
Thanks, Yong On Sat, Nov 2, 2019 at 18:01 Enrico Olivelli <eolive...@gmail.com> wrote: > Yong Zang, > Thank you for reporting this problem. > I can reproduce your problem and it is releated to the lack of -Dtwitter in > bin/common.sh > > Personally I don't this this is a blocker for a release as I feel that the > ability to run the server without explicitly building the sources is not > very useful in every day work. > Users usually use binaries/docker images and developers usually build the > source from Maven or the IDE. > > That said I will send a PR with the fix and maybe we can fix in a 4.10.1 > release or in case this RC fails and we have to send a new RC out for vote. > > If this is a blocker problem for you or anyone else please chime in. > > Enrico > > Il giorno ven 1 nov 2019 alle ore 06:26 Yong Zhang < > zhangyong1025...@gmail.com> ha scritto: > > > Hi Enrico, > > > > I verify the release candidate: > > > > - verify shasum of the source package and binary package > > - using binary package to start a standalone service is good > > - using the library to test the write and read are good > > > > But there are something wrong when I running standalone service after > > building the source packages.I ‘m not sure if that problem is caused by > > my operations. > > > > ``` > > ➜ bookkeeper-4.10.0 mvn clean install -DskipTests -Dtwitter -Dstream > > ➜ bookkeeper-4.10.0 bin/bookkeeper standalone > > JAVA_HOME not set, using java from PATH. (/usr/bin/java) > > the classpath of module 'stream/server' is not found, generating it ... > > see output at > > > /Users/zhangyong/java/release-bookie/bookkeeper-4.10.0/stream/server/target/build_classpath.out > > for the progress ... > > the classpath of module 'stream/server' is generated at > > > '/Users/zhangyong/java/release-bookie/bookkeeper-4.10.0/stream/server/target/cached_classpath.txt'. > > Error: Could not find or load main class > > org.apache.bookkeeper.stream.cluster.StandaloneStarter > > ➜ bookkeeper-4.10.0 bin/bookkeeper bookie > > JAVA_HOME not set, using java from PATH. (/usr/bin/java) > > the classpath of module 'bookkeeper-server' is not found, generating it > ... > > see output at > > > /Users/zhangyong/java/release-bookie/bookkeeper-4.10.0/bookkeeper-server/target/build_classpath.out > > for the progress ... > > the classpath of module 'bookkeeper-server' is generated at > > > '/Users/zhangyong/java/release-bookie/bookkeeper-4.10.0/bookkeeper-server/target/cached_classpath.txt'. > > Error: Could not find or load main class > org.apache.bookkeeper.server.Main > > ``` > > > > Using binary package the standalone service starts well. And using the > > master code to build it the service starts well too. When I checkout to > > v4.10.0-rc0 and rebuild it, the same problem appears. > > > > > > > > Thanks, > > Yong > > > > --- > > > On Oct 31, 2019, at 7:46 PM, Enrico Olivelli <eolive...@gmail.com> > > wrote: > > > > > > Hi everyone, > > > Please review and vote on the release candidate #0 for the version > > 4.10.0, > > > as follows: > > > [ ] +1, Approve the release > > > [ ] -1, Do not approve the release (please provide specific comments) > > > > > > The complete staging area is available for your review, which includes: > > > * Release notes [1] > > > * The official Apache source and binary distributions to be deployed to > > > dist.apache.org [2] > > > * All artifacts to be deployed to the Maven Central Repository [3] > > > * Source code tag "v4.10.0-rc0" [4] with git sha > > > 2f08377f5c56f96389fb3a8e51844844537e118b > > > > > > BookKeeper's KEYS file contains PGP keys we used to sign this release: > > > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS > > > > > > Please download these packages and review this release candidate: > > > > > > - Review release notes > > > - Download the source package (verify shasum, and asc) and follow the > > > instructions to build and run the bookkeeper service. > > > - Download the binary package (verify shasum, and asc) and follow the > > > instructions to run the bookkeeper service. > > > - Review maven repo, release tag, licenses, and any other things you > > think > > > it is important to a release. > > > > > > The vote will be open for at least 72 hours. It is adopted by majority > > > approval, with at least 3 PMC affirmative votes. > > > > > > Thanks, > > > Enrico Olivelli > > > > > > [1] > > > > > > https://github.com/apache/bookkeeper/pull/2165/commits/0d91a95f306031d85c6a8195b0e6d73523cbfc0a > > > [2] > > https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.10.0-rc0/ > > > [3] > > > > > > https://repository.apache.org/content/repositories/orgapachebookkeeper-1043/ > > > [4] https://github.com/apache/bookkeeper/tree/v4.10.0-rc0 > > > > >
