Hey Enrico, Thanks for putting the release together. I'm afraid there's an issue with the source package though.
~/blah/4.6.2-rc1 $ ls -l bookkeeper-4.6.2/bookkeeper-server/bin total 20 -rw-r--r-- 1 ivan ivan 7364 Mar 28 09:24 bookkeeper -rw-r--r-- 1 ivan ivan 2869 Mar 28 09:24 bookkeeper-cluster.sh -rw-r--r-- 1 ivan ivan 4357 Mar 28 09:24 bookkeeper-daemon.sh This also makes some tests fail (the rack awareness with script one). So, a -1 from me, for the package that's up there. Otherwise everything else was looking good. I may not even need to cut a new RC though, since this looks like a package generation issue, not something that needs to be in the branch. Did you generate on a fat32 filesystem or something? Cheers, Ivan On Tue, Apr 3, 2018 at 9:26 AM, Enrico Olivelli <eolive...@gmail.com> wrote: > Hi everyone, > Please review and vote on the release candidate #1 for the version 4.6.2, > as follows: > [ ] +1, Approve the release > [ ] -1, Do not approve the release (please provide specific comments) > > The complete staging area is available for your review, which includes: > * Release notes [1] > * The official Apache source and binary distributions to be deployed to > dist.apache.org [2] > * All artifacts to be deployed to the Maven Central Repository [3] > * Source code tag "release-4.6.2" [4] with git sha > 70c613f1700d4c19e36c10b5b51e841b138569fb > > BookKeeper's KEYS file contains PGP keys we used to sign this release: > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS > > Please download these packages and review this release candidate: > > - Review release notes > - Download the source package (verify shasum, and asc) and follow the > instructions to build and run the bookkeeper service. > - Download the binary package (verify shasum, and asc) and follow the > instructions to run the bookkeeper service. > - Review maven repo, release tag, licenses, and any other things you think > it is important to a release. > > The vote will be open for at least 72 hours. It is adopted by majority > approval, with at least 3 PMC affirmative votes. > > Thanks, > Enrico Olivelli > > [1] https://github.com/apache/bookkeeper/pull/1297/ > [2] > https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper/bookkeeper-4.6.2-rc1/ > [3] > https://repository.apache.org/content/repositories/orgapachebookkeeper-1025/ > [4] https://github.com/apache/bookkeeper/commits/release-4.6.2
