+1 (binding) 1) notices, licenses look good to me (I can be biased since I made that change) 2) md5, signature look good 3) binary package looks good (run standalone) 4) source package looks good (compile, test and run standalone) 5) artifactory, tag look good
Environment: OSX On Mon, Dec 18, 2017 at 10:37 PM, Enrico Olivelli <eolive...@gmail.com> wrote: > Il mar 19 dic 2017, 02:13 Jia Zhai <zhai...@apache.org> ha scritto: > > > Hi everyone, > > > > Please review and vote on the release candidate #2 for the version > > 4.6.0, as follows: > > [ ] +1, Approve the release > > [ ] -1, Do not approve the release (please provide specific comments) > > > > +1 > run tests from src package > Checked signatures and checksums > Run tests of my downstream projects > Performed basic shell classes commands and run a single machine ensemble > > Thank you Jia > Enrico > > > > > > This new release candidate mainly fixed the license issue, also removed > > bookkeeper-all package for it contains unclear license. > > > > The complete staging area is available for your review, which includes: > > * Release notes [1] > > * The official Apache source and binary distributions to be deployed > > to dist.apache.org [2] > > * All artifacts to be deployed to the Maven Central Repository [3] > > * Source code tag "release-4.6.0" [4] with sha 0d6c21e0a88749c428749841db > > 59cf53195e556c > > > > BookKeeper's KEYS file contains PGP keys we used to sign this > > release:https://dist.apache.org/repos/dist/release/bookkeeper/KEYS > > > > Please download these packages and review this release candidate: > > > > - Review release notes > > - Download the source package (verify md5, shasum, and asc) and follow > the > > instructions to build and run the bookkeeper service. > > - Download the binary package (verify md5, shasum, and asc) and follow > the > > instructions to run the bookkeeper service. > > - Review maven repo, release tag, licenses, and any other things you > think > > it is important to a release. > > > > The vote will be open for at least 72 hours. It is adopted by majority > > approval, with at least 3 PMC affirmative votes. > > > > Thanks, > > Jia Zhai > > > > [1] *https://github.com/apache/bookkeeper/pull/759 > > <https://github.com/apache/bookkeeper/pull/759>* > > [2] * > > https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.6.0-rc2/ > > <https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.6.0-rc2/ > >* > > [3] https://repository.apache.org/content/repositories/orgap > > achebookkeeper-1023/ > > [4] https://github.com/apache/bookkeeper/tree/release-4.6.0 > > > -- > > > -- Enrico Olivelli >
