Il mar 17 ott 2017, 22:13 Sijie Guo <guosi...@gmail.com> ha scritto:

> Looks good to me.
>

Great. Thank you Sijie
I think all is ok.
I will send an heads up email to inform that we are starting the release
process

While doing this I will take notes and fix the release guide in order to
support minor releases

Enrico


> - Sijie
>
> On Sun, Oct 15, 2017 at 6:56 AM, Enrico Olivelli <eolive...@gmail.com>
> wrote:
>
> > 2017-10-12 8:52 GMT+02:00 Enrico Olivelli <eolive...@gmail.com>:
> >
> > >
> > >
> > > 2017-10-11 18:30 GMT+02:00 Sijie Guo <guosi...@gmail.com>:
> > >
> > >> On Wed, Oct 11, 2017 at 6:50 AM, Enrico Olivelli <eolive...@gmail.com
> >
> > >> wrote:
> > >>
> > >> > OK,
> > >> > I did a first pass
> > >> >
> > >> > This is the list of issues labelled 4.5.1
> > >> > https://github.com/apache/bookkeeper/issues?utf8=%E2%9C%
> > >> > 93&q=label%3Arelease%2F4.5.1%20type%3Aissue%20
> > >> >
> > >> > This is the list of pr
> > >> > https://github.com/apache/bookkeeper/pulls?q=label%
> > >> > 3Arelease%2F4.5.1+type%3Apr
> > >> >
> > >> > This is from JIRA (1 issue)
> > >> >
> https://issues.apache.org/jira/projects/BOOKKEEPER/versions/12341342
> > >> > https://issues.apache.org/jira/browse/BOOKKEEPER-1105
> > >> >
> > >> > We have one issue and the corresponding pr not cherry-picked to
> > >> branch-4.5
> > >> > https://github.com/apache/bookkeeper/issues/414 Test failure in
> > >> > UpdateLedgerOpTest
> > >> > https://github.com/apache/bookkeeper/pull/424 Issue 414: use a
> clone
> > of
> > >> > baseconf in new ServerConfiguration(baseConf)
> > >> > Please note that issue 414 has a different description than pr 424
> and
> > >> it
> > >> > was "difficult" to perform the searc.
> > >> >
> > >> > This other issue has been cherry-picked but it did not have the
> 4.5.1
> > >> label
> > >> > https://github.com/apache/bookkeeper/issues/499
> > >> >
> > >> >
> > >> > For the issue 414 the fix is about changing the behaviour of
> > >> > ServerConfiguration. I don't know if it worth to include that fix, I
> > >> > propose not to cherry pick it.
> > >> >
> > >>
> > >> +1 we don't need to include 414 in 4.5.1. we just need to remove the
> > tags.
> > >>
> > >
> > > removed
> > >
> > >
> > >>
> > >>
> > >> >
> > >> > I have created a new 4.5.1 milestone and assigned all the issue to
> it
> > >> > https://github.com/apache/bookkeeper/milestone/3
> > >>
> > >>
> > >> I don't think we should use milestone for bug fixes release. A github
> > >> issue
> > >> can be associated with only one milestone. We should use the feature
> > >> release as the milestone.
> > >>
> > >> For bug releases, we should use only tags 'release/4.5.1'. The changes
> > >> land
> > >> in milestone first and then are cherry-picked to branches, so they
> > should
> > >> be associated with next feature release.
> > >>
> > >> You can check the merge script to learn how does it handle the
> milestone
> > >> and labels.
> > >>
> > >
> > > Okay,
> > > I misunderstood the release guide, maybe we will enhance it to deal
> > better
> > > with minor releases
> > >
> > >
> > >>
> > >>
> > >> >
> > >> >
> > >> > I noticed that an issue can have only one "milestone", so 499 has
> been
> > >> > moved from milestone 4.6.0 to 4.5.1
> > >> >
> > >> > This is a link to the release guide
> > >> > http://bookkeeper.apache.org/community/release_guide/
> > >> >
> > >> > I think I should create a new issue for "Release notes 4.5.1" and a
> > new
> > >> > issue for "Bump docker image to 4.5.1 on 4.5 branch"
> > >> >
> > >>
> > >> Yes.
> > >>
> > >
> > > created issues and assigned them to myself
> > >
> > > https://github.com/apache/bookkeeper/issues/554
> > > https://github.com/apache/bookkeeper/issues/555
> > >
> > >
> > > Currently all tests run fine on branch-4.5 a part from the known flaky
> > > org.apache.bookkeeper.bookie.BookieInitializationTest.
> > > testWithDiskFullAndAbilityToCreateNewIndexFile
> > > So I will prepare myself in the weekend (KEYS....) and I think I will
> be
> > > able to start the release process next week
> > >
> >
> >
> > I have added my GPG key (for eolive...@apache.org) to our  KEYS file
> >
> > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS
> >
> > I will appreciate if someone could check it
> >
> > Enrico
> >
> >
> >
> > >
> > > Please point out problems/issues for 4.5 as soon as you can
> > >
> > > -- Enrico
> > >
> > >
> > >
> > >
> > >>
> > >> >
> > >> >
> > >> > -- Enrico
> > >> >
> > >> >
> > >> >
> > >> >
> > >> >
> > >> > 2017-10-05 21:59 GMT+02:00 Sijie Guo <guosi...@gmail.com>:
> > >> >
> > >> > > We can move that to 4.6.
> > >> > >
> > >> > > - Sijie
> > >> > >
> > >> > > On Thu, Oct 5, 2017 at 12:33 PM, Enrico Olivelli <
> > eolive...@gmail.com
> > >> >
> > >> > > wrote:
> > >> > >
> > >> > > > Sijie,
> > >> > > > There is one open issue for 4.5.1, you created it. Are you going
> > to
> > >> > work
> > >> > > on
> > >> > > > it or we can do it for 4.6?
> > >> > > > Enrico
> > >> > > >
> > >> > > > Il gio 5 ott 2017, 04:34 Jia Zhai <zhaiji...@gmail.com> ha
> > scritto:
> > >> > > >
> > >> > > > > 👍 Thanks Enrico.
> > >> > > > >
> > >> > > > > On Wed, Oct 4, 2017 at 5:41 PM, Enrico Olivelli <
> > >> eolive...@gmail.com
> > >> > >
> > >> > > > > wrote:
> > >> > > > >
> > >> > > > > > 2017-10-04 9:59 GMT+02:00 Sijie Guo <guosi...@gmail.com>:
> > >> > > > > >
> > >> > > > > > > Hi all,
> > >> > > > > > >
> > >> > > > > > > when you are merging a pr that was tagged for bug fix
> > releases
> > >> > > (such
> > >> > > > as
> > >> > > > > > > release/4.5.1), please make sure you cherry-pick the
> change
> > to
> > >> > > > > > > corresponding branch. The merge script has the
> instructions
> > >> for
> > >> > > doing
> > >> > > > > > that.
> > >> > > > > > > Please follow it.
> > >> > > > > > >
> > >> > > > > > > It has been a month since 4.5.0. There are a few critical
> > bug
> > >> > fixes
> > >> > > > --
> > >> > > > > > > rackware placement fix, prometheus fix. I think it is
> ready
> > >> for
> > >> > > > > cutting a
> > >> > > > > > > bug fix release 4.5.1. Anyone volunteers for this?
> > >> > > > > > >
> > >> > > > > >
> > >> > > > > >
> > >> > > > > > In theory I was the volunteer release manager for 4.5.1.
> > >> > > > > > I can do.
> > >> > > > > > I think I will need your help
> > >> > > > > >
> > >> > > > > > Enrico
> > >> > > > > >
> > >> > > > > >
> > >> > > > > >
> > >> > > > > > >
> > >> > > > > > > - Sijie
> > >> > > > > > >
> > >> > > > > >
> > >> > > > >
> > >> > > > --
> > >> > > >
> > >> > > >
> > >> > > > -- Enrico Olivelli
> > >> > > >
> > >> > >
> > >> >
> > >>
> > >
> > >
> >
>
-- 


-- Enrico Olivelli

Reply via email to