Hello Julian, I don’t know RAT very well, but I’ve noticed it can succeed with unlicensed files displayed in the report. For instance, in the RC2, some pom.xml files were missing the license header, and this issue only appeared in the report. Unlicensed favicon.ico files were also flagged in the report and I removed them in our release branch.
Please note that we have some exclusions in our main pom.xml (I hope it’s not the cause of the problem). These exclusions are for files with undetected licenses, files that have been audited individually, and files that cannot contain a license Best regards, Bertil > On 4 Dec 2024, at 21:26, Julian Hyde <jh...@apache.org> wrote: > > As I stated in my vote [1], I ran RAT on rc2, and it succeeded. > > $ ./mvnw apache-rat:rat > ... > [INFO] baremaps-cli ....................................... SUCCESS [ 0.096 > s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 4.035 s > [INFO] Finished at: 2024-12-04T12:24:23-08:00 > [INFO] > ------------------------------------------------------------------------ > $ > > Did I miss something? > > Julian > > [1] https://lists.apache.org/thread/0vzq3ck9j52p52fo9v8j818bmrsh02k4 > > On 2024/12/03 12:38:25 Bertil Chapuis wrote: >> Hello Everyone, >> >> We haven’t been able to gather the necessary votes for this release >> candidate. In the meantime, and following the explanations provided on the >> main mailing list, I ran Apache RAT and identified a couple of missing >> headers in our pom.xml files. Apparently, everything needs to be almost >> perfect for the release candidate to be accepted. Therefore, I am canceling >> this vote. >> >> I will also make two additional changes to streamline our release process: >> - Add an Apache RAT check to our CI >> - Include our LICENSE and NOTICE files in the JARs we will deploy to Maven >> Central >> >> I hope to drop a new release candidate by the end of the week and that >> future releases will go more smoothly. >> >> Thank you for your help and patience. >> >> Best regards, >> >> Bertil >> >>> On 29 Nov 2024, at 10:29, Bertil Chapuis <bchap...@gmail.com> wrote: >>> >>> Hello Everyone, >>> >>> As noted on the general mailing list, we should begin with a vote on the >>> dev mailing list. Even if you previously voted positively for Release >>> Candidate 2, I kindly ask you to vote again for Release Candidate 3. I >>> understand this requires some effort, but I truly believe it’s worth it! As >>> we become more familiar with the process and continue addressing issues, >>> I’m confident we’ll soon be able to have Release Candidate 1 approved in >>> less than a week. This is the way! 😊 >>> >>> This release candidate fixes the licensing issues identified by Justin >>> Mclean and Calvin Kirs during the vote for the release candidate 2 and we >>> thank them for their feedback. >>> https://lists.apache.org/thread/wfl5d4z3srsr0qw52fn9t4lo137oq1nr >>> >>> You can read the release notes here: >>> https://github.com/apache/incubator-baremaps/releases/tag/v0.8.1-rc3 >>> >>> The commit to be voted upon: >>> https://github.com/apache/incubator-baremaps/tree/v0.8.1-rc3 >>> >>> Its tag is v0.8.1-rc3 and its hash is >>> 6fa41aeecad754a3cdc9dc6a2d99e6c5e79fe9c0. >>> >>> The artifacts to be voted on are located here: >>> https://dist.apache.org/repos/dist/dev/incubator/baremaps/0.8.1-rc3/ >>> >>> The hashes of the artifacts are as follows: >>> df4ffb644c020f8be5d923922c405e0a5837935b7de5db9f82a3c2dd5dff1cc0168debaf5136f1cb599747ae89cd69d1bd3f2d9f1083762a746f1ed0bfeecead >>> ./apache-baremaps-0.8.1-rc3-incubating-src.tar.gz >>> ed4a7f05fab61d3ed33441370225c3cf212c7368dac8bf82cdc948a4f9574ca51e82f91d82a99f3223064fae30a676f6a4b71dcbc8eb2ab3e21112bbadb18b4e >>> ./apache-baremaps-0.8.1-rc3-incubating-bin.tar.gz >>> >>> Release candidate artifacts are signed automatically with the key >>> (C81AC42AF2A7CACDF4C8A4F6936E280DF16599CB) created by the INFRA team: >>> https://downloads.apache.org/incubator/baremaps/KEYS >>> >>> The README file for the src distribution contains instructions for building >>> and testing the release. >>> >>> Please vote on releasing this package as Apache Baremaps 0.8.1 (incubating). >>> >>> The vote is open for 72 hours but can be open longer if the required number >>> of votes is not obtained. It passes if a majority of at least three +1 PPMC >>> votes are cast. >>> [ ] +1 Release this package as Apache Baremaps 0.8.1 (incubating) >>> [ ] 0 I don't feel strongly about it, but I'm okay with the release >>> [ ] -1 Do not release this package because... >>> >>> Here is my vote. >>> >>> +1 (non-binding): >>> - checked the presence of the LICENSE, NOTICE, and DISCLAIMER files in src >>> and bin; >>> - checked the presence of the licenses and notices directories in src and >>> bin; >>> - built from source; >>> - executed the binary distribution; >>> - checked the checksums; >>> - checked the signatures. >>> >>> Best regards, >>> >>> Bertil >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@baremaps.apache.org >> For additional commands, e-mail: dev-h...@baremaps.apache.org >> >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@baremaps.apache.org > For additional commands, e-mail: dev-h...@baremaps.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@baremaps.apache.org For additional commands, e-mail: dev-h...@baremaps.apache.org
