Thanks JB, I'll take at look at the PR. Can we include #2732 <https://github.com/apache/avro/pull/2732> as well?
Kind regards, Fokko Op do 18 apr 2024 om 08:45 schreef Jean-Baptiste Onofré <j...@nanthrax.net>: > Hi folks, > > I updated the PR (https://github.com/apache/avro/pull/2855) to fully > build with Java 11 min. > > Do we have a consensus to bump directly to Java 17 ? If so, I will > update the PR accordingly, using Java 17 by default and adding Java 22 > in the test scope. > > Regards > JB > > On Tue, Apr 16, 2024 at 3:29 PM Jean-Baptiste Onofré <j...@nanthrax.net> > wrote: > > > > Hi Fokko > > > > I'm happy to bump directly to Java 17 if everyone is OK with that. > > I can update the Jira ticket and the PR accordingly. > > > > Regards > > JB > > > > On Tue, Apr 16, 2024 at 4:22 PM Driesprong, Fokko <fo...@driesprong.frl> > wrote: > > > > > > Hey JB, > > > > > > Thanks for taking the lead here. Let me know if there is anything I can > > > help with. > > > > > > With regards to the Java version bump, I'm open to going to JDK17 > directly. > > > This is also the case for Spark 4 as well: > > > https://spark.apache.org/docs/3.5.1/building-spark.html#apache-maven > > > > > > Kind regards, > > > Fokko > > > > > > Op di 16 apr 2024 om 15:56 schreef Jean-Baptiste Onofré < > j...@nanthrax.net>: > > > > > > > Hi, > > > > > > > > follow up on this discussion, I created > > > > https://github.com/apache/avro/pull/2855 > > > > > > > > I'm working on some new PRs heading to the releases :) > > > > > > > > Thanks! > > > > Regards > > > > JB > > > > > > > > On Tue, Apr 16, 2024 at 10:55 AM Martin Grigorov < > mgrigo...@apache.org> > > > > wrote: > > > > > > > > > > On Tue, 16 Apr 2024 at 11:21, Jean-Baptiste Onofré < > j...@nanthrax.net> > > > > wrote: > > > > > > > > > > > Hi Martin, > > > > > > > > > > > > (finally I received the email from the list cleanly, w00t ;)) > > > > > > > > > > > > Thanks for pointing the previous discussion. > > > > > > > > > > > > I think 1.12.0 is OK as it's mostly the Java part that gonna be > > > > > > impacted. I think 2.0.0 would make more sense for a spec change > > > > > > impacting all languages. > > > > > > > > > > > > So, I'm proposing: > > > > > > - Avro 1.12.0 with Java 11 by default in Java > > > > > > - Avro 1.11.4 still on Java 8. > > > > > > It makes sense to maintain both to give users the time to update > (and > > > > > > encourage them to do so :)). > > > > > > > > > > > > Thoughts ? > > > > > > > > > > > > > > > +1 > > > > > > > > > > > > > > > > > > > > > > Regards > > > > > > JB > > > > > > > > > > > > On Tue, Apr 16, 2024 at 9:54 AM Martin Grigorov < > mgrigo...@apache.org> > > > > > > wrote: > > > > > > > > > > > > > > Hi, > > > > > > > > > > > > > > There were few discussions about this some months ago, e.g. > > > > > > > > https://lists.apache.org/thread/bd39zhk655pgzfctq763vp3z4xrjpx58 > > > > > > > I think everyone agreed that 1.12.0 could be bumped to Java > 11+! > > > > > > > > https://lists.apache.org/thread/b8d7cjywz6mpj81bhbx5tz6flbvwzsdk - > > > > here > > > > > > > Niels even suggested to bump the version to 2.0.0, but since > Avro is > > > > > > > multi-language repo I don't think changing the version to 2.x > for all > > > > > > langs > > > > > > > makes sense. > > > > > > > Users of Java 8 will have to stay with 1.11.x. There was > another > > > > > > discussion > > > > > > > at dev@ about maintaining both branches for some time. > > > > > > > > > > > > > > Martin > > > > > > > > > > > > > > On Mon, Apr 15, 2024 at 4:11 PM Jean-Baptiste Onofré < > > > > j...@nanthrax.net> > > > > > > > wrote: > > > > > > > > > > > > > > > Hi folks, > > > > > > > > > > > > > > > > NB: I'm sending this email with my regular email address ;) > > > > > > > > > > > > > > > > I'm doing a full pass to prepare Avro 1.11.4 and 1.12.0 > releases. > > > > > > > > > > > > > > > > I have a question for you: on the main branch (e.g. 1.12.0), > I > > > > propose > > > > > > > > to update the Java source/release target version to 11 > (instead of > > > > > > > > 1.8). I'm testing it right now, and so far so good. > > > > > > > > > > > > > > > > I'm also preparing some updates and cleanup. I will open the > PRs > > > > today. > > > > > > > > > > > > > > > > Thanks ! > > > > > > > > Regards > > > > > > > > JB > > > > > > > > > > > > > > > > > > >
