+1 for going ahead. Most pending merges are improvements than seem not blocking.
Thanks Ryan for all your work to make this happen! On Mon, Jul 25, 2022 at 9:52 PM Martin Grigorov <mgrigo...@apache.org> wrote: > > Hi, > > +1 for option 1. > > IMO we should make releases more often instead of postponing the releases > trying to add as much as possible. This way it would be easier to fix > regressions too. > > On Mon, Jul 25, 2022 at 8:26 PM Ryan Skraba <r...@skraba.com> wrote: > > > Hello again, one more status update! I've been away from the computer > > for the last week. Ideally, I was really hoping to get the 1.11.1 RC1 > > ready for review before leaving, but quite a few unexpected things > > have been consuming my time (not to mention more travelling coming > > up). > > > > I'd like to offer my sincere apologies to those who have been waiting > > for a committer to review and merge their contributions. Personally, > > I haven't been looking at anything else, unless it's specifically > > tagged for the 1.11.1 release, and it's been weighing on me. > > > > At this point, it looks like we have a couple of alternatives: > > > > 1. Prepare a 1.11.1 RC1 as a candidate as a branch AS IS, with (again) > > apologies for those who have outstanding, unreviewed PRs, pushing the > > remaining JIRA tagged for 1.11.1 to a later release, or > > > > 2. Continue as we are to make sure that everyone's work is included > > and the release is as complete as possible, even if it means delaying > > a couple more weeks. > > > > Regardless, I'd love to have the discussion on our efficiency on > > getting contributions merged... ideally after we get this one big task > > finished :D > > > > If there's no strong objection, I can prepare a 1.11.1 RC1 tomorrow. > > If we decide to continue adding work to the branch, we can always > > reject that release candidate! > > > > All my best, Ryan > > > > > > On Mon, Jul 4, 2022 at 7:15 PM Ryan Skraba <r...@skraba.com> wrote: > > > > > > Hello everyone! Just a quick status update -- a LOT of great PRs have > > > been merged for 1.11.1, but it's dragging on. There's a couple of > > > unreviewed or unmerged PRs that are pretty good matches for this > > > release[1]. > > > > > > I have some unexpected travel coming up (tomorrow), but I still want > > > to get an RC out ASAP. Thanks very much for the people who have been > > > diligently reviewing and my apologies to the contributors who have > > > been kept waiting! > > > > > > Once this release is out, we can probably start to discuss ways to > > > improve the process for the next time! > > > > > > All my best regards, Ryan > > > > > > [1]: > > https://issues.apache.org/jira/issues/?jql=project%20%3D%20AVRO%20AND%20fixVersion%20%3D%201.11.1%20AND%20status%20!%3D%20Resolved > > > > > > On Tue, Jun 28, 2022 at 8:48 PM Ryan Skraba <r...@skraba.com> wrote: > > > > > > > > Hello! > > > > > > > > Here's one way people can help get this release out -- I've published > > > > the website _almost_ as is for the next release at > > > > https://avro-site.skraba.com > > > > > > > > Of course, this is NOT the final destination, and in the future, > > > > hopefully we'll have a better place to review changes before > > > > publishing. > > > > > > > > Can you give it a look and see if there is anything that would BLOCK > > > > replacing avro.apache.org with this website? If there is, please > > > > don't hesitate to raise a JIRA subtask at AVRO-2175. > > > > > > > > Of course, if you find problems and improvements that don't block the > > > > release, don't hesitate to raise a JIRA anyway (under AVRO-3264, for > > > > example, for main page improvements). > > > > > > > > All my best, Ryan > > > > > > > > On Wed, Jun 22, 2022 at 9:11 PM Ryan Skraba <r...@skraba.com> wrote: > > > > > > > > > > Hello everyone! > > > > > > > > > > I've been trying to wrap up the release -- it's taken a lot longer > > > > > than I anticipated, my apologies for those who are waiting. I've > > > > > managed to merge a lot of PRs, but here's the list of outstanding > > > > > tasks: > > > > > > > > > > # AVRO-3539 Publish version-specific docs for each release > > > > > > > > > > This is part of the newly refactored website. Essentially, I've been > > > > > testing the build to see how it would work for the next releases > > > > > (1.11.2, 1.12.0, etc). There are currently some minor issues that > > I'm > > > > > working out. > > > > > > > > > > I'm not too worried that the website be perfect, once it's in the git > > > > > repo we can probably start seeing contributions and improvements > > > > > rapidly! > > > > > > > > > > # AVRO-3531 PR#1719 GenericDatumReader in multithread lead to > > infinite > > > > > loop cause misused of IdentityHashMap > > > > > > > > > > The PR is in good shape, but is super difficult to test. I'm running > > > > > through it. > > > > > > > > > > # AVRO-3473 PR#1624 Automatically register Conversion<T> classes > > > > > > > > > > Next on my list! > > > > > > > > > > # AVRO-3377 PR#1527 Deserialization of record of mangled Java class > > > > > throws ClassCastException > > > > > > > > > > I haven't had a chance to look at this yet. > > > > > > > > > > # AVRO-3266 PR#1431 / PR#1618 Output stream incompatible with > > > > > MagicS3GuardCommitter > > > > > > > > > > There are two PRs, both look fine but which one we pick depends on > > > > > whether we drop Hadoop 2. I'd love to hear your opinion! > > > > > > > > > > # AVRO-3219 PR#1348 Not support for nullable enum type fields > > > > > > > > > > We need a C# expert to take a look at this one. > > > > > > > > > > # AVRO-2872 PR#1097 'conversions' array is not populated for Avro > > > > > Union Logicaltype fields > > > > > > > > > > I have to admit, this one is baffling me, and I haven't been able to > > > > > figure out what the consequence is of NOT merging it. > > > > > > > > > > Thanks to everyone who has been reviewing, committing and > > > > > cherrypicking so far! I'm going to continue, but my goal is to have > > a > > > > > hosted website before the weekend for people to pick at, and to > > create > > > > > the RC early next week. During this time, I'll keep in better touch > > > > > here. > > > > > > > > > > All my best, Ryan > > > > > > > > > > On Fri, Jun 3, 2022 at 8:42 AM Martin Grigorov <mgrigo...@apache.org> > > wrote: > > > > > > > > > > > > Hi Ryan, > > > > > > > > > > > > On Thu, Jun 2, 2022 at 8:27 PM Ryan Skraba <r...@skraba.com> > > wrote: > > > > > > > > > > > > > OK! I'm back on this subject and interested in getting this > > done! I > > > > > > > was blocked for a while on > > > > > > > https://issues.apache.org/jira/browse/AVRO-3454, but I think > > I've > > > > > > > found a workaround. > > > > > > > > > > > > > > For all of the interest in shadowing the release, we'll try to > > find a > > > > > > > common time. Don't worry too much about missing out if we can't > > > > > > > arrange a common time -- this could be something that we do for > > all > > > > > > > releases, for as long as there are contributors that find it > > > > > > > worthwhile! > > > > > > > > > > > > > > I think the process is not significantly different than what > > we've > > > > > > > documented, but it's especially useful to have extra eyes to > > point out > > > > > > > what we no longer notice. > > > > > > > > > > > > > > My apologies for letting this release drag on for quite a while > > > > > > > (nearly 3 months) -- just a reminder if you've seen something > > checked > > > > > > > into master that is a good candidate for 1.11.1, don't hesitate > > to > > > > > > > bring it up here! > > > > > > > > > > > > > > > > > > > Almost everything in Rust, C# and Python is committed in both > > master and > > > > > > branch-1.11. > > > > > > There are open PRs for the Java library which wait for someone more > > > > > > knowledgeable in that area (you :-) ) to review and merge. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > All my best, Ryan > > > > > > > > > > > > > > > > > > > > > On Wed, May 11, 2022 at 11:13 AM Oscar Westra van Holthe - Kind > > > > > > > <os...@westravanholthe.nl> wrote: > > > > > > > > > > > > > > > > For me, after 19:00 or Mon,Tue,Thu,Fri between 7:30-16:00 (all > > UTC) > > > > > > > > > > > > > > > > > > > > > > > > Oscar Westra van Holthe - Kind <os...@westravanholthe.nl> > > > > > > > > > > > > > > > > Op wo 11 mei 2022 10:00 schreef Martin Grigorov < > > mgrigo...@apache.org>: > > > > > > > > > > > > > > > > > Hi, > > > > > > > > > > > > > > > > > > Me too! > > > > > > > > > > > > > > > > > > Now I guess it will be harder to find a timeslot where all > > of us could > > > > > > > do > > > > > > > > > it :-) > > > > > > > > > I could find time during the working hours (5:00-14:00 UTC) > > and after > > > > > > > 18:00 > > > > > > > > > UTC. > > > > > > > > > > > > > > > > > > Martin > > > > > > > > > > > > > > > > > > On Wed, May 11, 2022 at 8:16 AM Oscar Westra van Holthe - > > Kind < > > > > > > > > > os...@westravanholthe.nl> wrote: > > > > > > > > > > > > > > > > > > > Hi, > > > > > > > > > > > > > > > > > > > > I'd also like to help/shadow, as the release contains a > > feature that > > > > > > > > > would > > > > > > > > > > help me a lot. Also, the sooner we have a release, the > > sooner the > > > > > > > new > > > > > > > > > > ANTLR grammar for the 1.12 release can be tested with more > > than just > > > > > > > the > > > > > > > > > > test cases. > > > > > > > > > > > > > > > > > > > > Kind regards, > > > > > > > > > > Oscar > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > Oscar Westra van Holthe - Kind <os...@westravanholthe.nl> > > > > > > > > > > > > > > > > > > > > Op wo 11 mei 2022 05:20 schreef Jack Klamer < > > jfkla...@gmail.com>: > > > > > > > > > > > > > > > > > > > > > I would love to help/shadow, because I believe I am the > > most > > > > > > > likely to > > > > > > > > > > have > > > > > > > > > > > broken something and I have added complexity to the rust > > packaging > > > > > > > > > > process > > > > > > > > > > > that is not yet well scripted/automated. > > > > > > > > > > > > > > > > > > > > > > Best, > > > > > > > > > > > Jack > > > > > > > > > > > > > > > > > > > > > > On Tue, May 10, 2022 at 10:55 AM Ryan Skraba < > > r...@skraba.com> > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > Hello everyone! My apologies for being absent lately. > > I've had > > > > > > > some > > > > > > > > > > > > professional and personal travel and I didn't have the > > spare time > > > > > > > > > that > > > > > > > > > > > > I thought I might! > > > > > > > > > > > > > > > > > > > > > > > > I'd love to continue with the 1.11.1 release -- it > > looks like > > > > > > > there's > > > > > > > > > > > > less than a dozen issues still tagged in JIRA (some of > > them > > > > > > > mine...) > > > > > > > > > > > > The website is in pretty good shape, for example. > > > > > > > > > > > > > > > > > > > > > > > > Would anyone like to shadow the"release process live > > this time? > > > > > > > We > > > > > > > > > > > > could probably do this with a slack call and a shared > > screen. > > > > > > > It's > > > > > > > > > > > > not significantly difficult (less than 30 minutes) but > > it takes > > > > > > > place > > > > > > > > > > > > in two parts --> building the artifacts before calling > > a vote and > > > > > > > > > > > > publishing the artifacts after the vote passes. > > > > > > > > > > > > > > > > > > > > > > > > I'm currently catching up on the mailing lists, but we > > could > > > > > > > probably > > > > > > > > > > > > do this in the next two weeks. Even if the release > > > > > > > documentation is > > > > > > > > > > > > pretty good, it would be a good way to share how it > > currently > > > > > > > works. > > > > > > > > > > > > My only constraint is that it would have to be > > scheduled after > > > > > > > 17:00 > > > > > > > > > > > > UTC or on the weekend! > > > > > > > > > > > > > > > > > > > > > > > > All my best, Ryan > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Tue, Mar 22, 2022 at 10:34 AM Martin Grigorov < > > > > > > > > > mgrigo...@apache.org > > > > > > > > > > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > Hi, > > > > > > > > > > > > > > > > > > > > > > > > > > Thanks to Jack Klamer there are no known issues in > > the Rust > > > > > > > SDK! > > > > > > > > > > > > > > > > > > > > > > > > > > In the coming days I will add "Getting started" > > guide for Rust > > > > > > > in > > > > > > > > > the > > > > > > > > > > > new > > > > > > > > > > > > > website! > > > > > > > > > > > > > > > > > > > > > > > > > > Martin > > > > > > > > > > > > > > > > > > > > > > > > > > On Sun, Mar 20, 2022 at 12:46 AM Jack Klamer < > > > > > > > jfkla...@gmail.com> > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > That PR has been merged thanks to the work of > > Martin! I > > > > > > > believe > > > > > > > > > > there > > > > > > > > > > > > may > > > > > > > > > > > > > > be more work to do in this vein but that PR covers > > some of > > > > > > > the > > > > > > > > > main > > > > > > > > > > > > > > workflows that are affected. > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Fri, Mar 18, 2022 at 1:40 PM Ryan Skraba < > > r...@skraba.com > > > > > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Hello Jack! How long do you you'll need? > > There's a lot of > > > > > > > > > open > > > > > > > > > > > PRs > > > > > > > > > > > > > > > that we can evaluate in the meantime, so if it's > > worth it > > > > > > > to > > > > > > > > > > delay > > > > > > > > > > > a > > > > > > > > > > > > > > > release a couple of weeks, then I have no > > objection! > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Ideally, I'd like to see more frequent releases, > > so that > > > > > > > it's > > > > > > > > > not > > > > > > > > > > > > such > > > > > > > > > > > > > > > a big deal when someone's PR doesn't make it in > > for review > > > > > > > > > > reasons > > > > > > > > > > > :/ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > In the meantime, there's still some things to do > > in the > > > > > > > JIRA > > > > > > > > > set > > > > > > > > > > > for > > > > > > > > > > > > > > > 1.11.1, I'll send another message if we start > > getting > > > > > > > closer. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > All my best and thanks for your work! Ryan > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Mon, Mar 14, 2022 at 4:22 PM Jack Klamer < > > > > > > > > > jfkla...@gmail.com> > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Hey all, > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > I would personally love to get in > > > > > > > > > > > > > > > > https://github.com/apache/avro/pull/1602 as > > it contains > > > > > > > a > > > > > > > > > bug > > > > > > > > > > > fix > > > > > > > > > > > > for > > > > > > > > > > > > > > a > > > > > > > > > > > > > > > > decently likely scenario. However it may take > > longer to > > > > > > > get > > > > > > > > > > that > > > > > > > > > > > in > > > > > > > > > > > > > > than > > > > > > > > > > > > > > > > the desired release time here, but I’ll do > > what I can to > > > > > > > meet > > > > > > > > > > the > > > > > > > > > > > > > > > deadline. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Best, > > > > > > > > > > > > > > > > Jack > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Mon, Mar 14, 2022 at 10:11 AM Oscar Westra > > van Holthe > > > > > > > - > > > > > > > > > > Kind < > > > > > > > > > > > > > > > > os...@westravanholthe.nl> wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Hi all, > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > +1 for a minor release > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > From what I can see, there's indeed enough > > for a new > > > > > > > > > release. > > > > > > > > > > > > > > > Especially > > > > > > > > > > > > > > > > > the C# and Rust improvements merit a release. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Kind regards > > > > > > > > > > > > > > > > > Oscar > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Tue, 8 Mar 2022 at 19:30, Ryan Skraba < > > > > > > > r...@skraba.com> > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Hello! > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > There's about 150 issues that have been > > resolved[1] > > > > > > > and > > > > > > > > > > > cherry > > > > > > > > > > > > > > picked > > > > > > > > > > > > > > > > > > into branch-1.11 since the last release > > (including > > > > > > > the > > > > > > > > > one > > > > > > > > > > > that > > > > > > > > > > > > > > bumps > > > > > > > > > > > > > > > > > > us off of the log4j CVE radar, even if we > > aren't > > > > > > > > > vulnerable > > > > > > > > > > > as > > > > > > > > > > > > is). > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > We've been pretty rigorous with > > cherry-picking back > > > > > > > to > > > > > > > > > the > > > > > > > > > > > > > > > branch-1.11 > > > > > > > > > > > > > > > > > > so it would probably be a pretty easy > > release this > > > > > > > time > > > > > > > > > > > around! > > > > > > > > > > > > > > What > > > > > > > > > > > > > > > > > > do you think about starting the process? > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > There's still a bit of work that I'd like > > to see in > > > > > > > the > > > > > > > > > > > website > > > > > > > > > > > > > > and a > > > > > > > > > > > > > > > > > > few open issues[2] targeted to 1.11.1, and > > many open > > > > > > > PRs > > > > > > > > > > that > > > > > > > > > > > > might > > > > > > > > > > > > > > > be > > > > > > > > > > > > > > > > > > candidates. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > What do you think? Is it the right time > > to think > > > > > > > about > > > > > > > > > it? > > > > > > > > > > > Is > > > > > > > > > > > > > > there > > > > > > > > > > > > > > > > > > anything blocking a new minor release? > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > If you have an open PR or favourite JIRA > > that hasn't > > > > > > > been > > > > > > > > > > > > > > addressed, > > > > > > > > > > > > > > > > > > don't hesitate to bring it up, or update > > the > > > > > > > fixVersion. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > All my best, Ryan > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > [1]: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://issues.apache.org/jira/issues/?jql=project%3DAVRO%20AND%20fixVersion%3D1.11.1%20AND%20status%3DResolved > > > > > > > > > > > > > > > > > > [2]: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://issues.apache.org/jira/issues/?jql=project%3DAVRO%20AND%20fixVersion%3D1.11.1%20AND%20status!%3D%20Resolved > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ✉️ Oscar Westra van Holthe - Kind < > > > > > > > > > os...@westravanholthe.nl> > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >
