Hi, > Thanks for your feedback. No problem.
> It's pretty much equivalent to a pristine upstream jar. We do have a > ticket (https://issues.apache.org/jira/browse/AURORA-353) to move from > having them checked in to pulled in as part of the build; IMO it's fine to bundled 3rd party stuff in (with correct licences) and it does give you control over the versions / ability to make changes. Downloading them would simplify the LICENSE file. > The generated gradle wrapper script (and associated jar) eliminates the > need to have multiple versions of gradle installed and allows the project > to explicitly specify its dependency on a particular gradle version. Perhaps put something in the release notes about that so people know why the jar is there? There may be some questions about including a jar in the source even if gradle recommends doing that. I assume there's no way you could compile the jar from source as part of the build or download the jar? > KEYS are available both inside and outside the release package. Do you > suggest removing them from the source distribution? Up to you. I haven't noticed it inside a package before. IMO it's certainly not an something that would stop a release. > These are actually BUILD configuration files for pants Was unaware of that - thanks for clearing it up. Thanks, Justin
